Exclude visualization types from flake8 testing (#1925)

* Moved visualization types to types subdirectory

* Updated flake8 test to ignore types subdirectory

.travis.yml

@@ -101,4 +101,4 @@ matrix:
       language: python
       python: "3.7"
       install: pip install flake8
-      script: flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+      script: flake8 . --count --exclude=backend/src/apiserver/visualization/types/*.py --select=E9,F63,F7,F82 --show-source --statistics

backend/src/apiserver/visualization/server.py

@@ -126,7 +126,7 @@ def generate_notebook_from_arguments(
         nb = new_notebook()
         nb.cells.append(_exporter.create_cell_from_args(arguments))
         nb.cells.append(new_code_cell('source = "{}"'.format(source)))
-        visualization_file = str(Path.cwd() / "{}.py".format(visualization_type))
+        visualization_file = str(Path.cwd() / "types/{}.py".format(visualization_type))
         nb.cells.append(_exporter.create_cell_from_file(visualization_file))
         return nb
 

backend/src/apiserver/visualization/test_exporter.py

@@ -58,7 +58,7 @@ def test_create_cell_from_args_with_multiple_args(self):
 
     def test_create_cell_from_file(self):
         self.maxDiff = None
-        cell = self.exporter.create_cell_from_file("test.py")
+        cell = self.exporter.create_cell_from_file("types/test.py")
         self.assertMatchSnapshot(cell.source)
 
     def test_generate_html_from_notebook(self):

backend/src/apiserver/visualization/roc_curve.py → backend/src/apiserver/visualization/types/roc_curve.py

@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# flake8: noqa TODO
-
 import json
 from pathlib import Path
 from bokeh.layouts import row

backend/src/apiserver/visualization/tfdv.py → backend/src/apiserver/visualization/types/tfdv.py

@@ -20,6 +20,6 @@
 #
 # source
 
-train_stats = tfdv.generate_statistics_from_csv(data_location=source)  # noqa: F821
+train_stats = tfdv.generate_statistics_from_csv(data_location=source)
 
 tfdv.visualize_statistics(train_stats)

backend/src/apiserver/visualization/tfma.py → backend/src/apiserver/visualization/types/tfma.py

@@ -14,8 +14,6 @@
 
 import tensorflow_model_analysis as tfma
 
-# flake8: noqa TODO
-
 if variables.get("slicing_column", False) == False {
     tfma.view.render_slicing_metrics(source)
 } else {