Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom visualization support for Python based visualizations #1929

Merged
merged 8 commits into from
Aug 25, 2019
Merged

Add custom visualization support for Python based visualizations #1929

merged 8 commits into from
Aug 25, 2019

Commits on Aug 24, 2019

  1. Added custom visualization type

    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    44972f9 View commit details
    Browse the repository at this point in the history

  2. Added support for custom visualizations to the VisualizationCreator c… 

    …omponent
    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    31b837c View commit details
    Browse the repository at this point in the history

  3. Re-generated API

    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    9e0ab43 View commit details
    Browse the repository at this point in the history

  4. Updated VisualizationCreator.test.tsx.snap

    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    573abaa View commit details
    Browse the repository at this point in the history

  5. Updated VisualizationCreator.test.tsx tohave new and more specific tests 

    * Added tests to ensure Editor component is visible when specifying visualization type
* Updated test to properly validate provided source is rendered
    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    ad85a3e View commit details
    Browse the repository at this point in the history

  6. Added unit test to ensure that an argument placeholder is provided fo… 

    …r every visualization type
    @ajchili
    ajchili committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    d90d698 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Fixed linting error

    @ajchili
    ajchili committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    713c862 View commit details
    Browse the repository at this point in the history

  2. Simplified canGenerate logic

    @ajchili
    ajchili committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    052d77d View commit details
    Browse the repository at this point in the history