Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new kubernetes packages contain breaking change, thus fixing the version in the sample test image #1159

Merged
merged 3 commits into from
Apr 15, 2019
Merged

new kubernetes packages contain breaking change, thus fixing the version in the sample test image #1159

merged 3 commits into from
Apr 15, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Apr 12, 2019

This change is Reviewable

@gaoning777 gaoning777 changed the title new kubernetes packages contain breaking change, thus fixing the version new kubernetes packages contain breaking change, thus fixing the version in the sample test image Apr 12, 2019
@IronPan
Copy link
Member

IronPan commented Apr 12, 2019

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 13, 2019

What was the breaking change?
\lgtm

@gaoning777
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 71325c3 into kubeflow:master Apr 15, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
…ubeflow#1343)

* parent a0a52f8
author Manasvi Tickoo <MTICKOO@bloomberg.net> 1611275174 -0500
committer Manasvi Tickoo <MTICKOO@bloomberg.net> 1612370131 -0500

1159 - cloudevent support ofr kfserving

PR comments

Fix clpudevent headers

Add unit test for cloud event messages

Add avro unit test

Add avro to kfserving requirements.txt

PR comments

kfserving check ce-contenttyp before unmarshalling

Update k8s libraries to 0.19.2 (kubeflow#1305)

* go mod tidy

* Update k8s libs to 0.19.2, fix issues, and run make tests

* Handle ce to_binary return type wile building resp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants