kustomize kf pipeline #1305

IronPan · 2019-05-09T23:40:34Z

This change is

Ark-kun · 2019-05-10T06:25:39Z

experimental/manifests/base/argo/workflow-controller-configmap.yaml

+    artifactRepository:
+    {
+        s3: {
+            bucket: mlpipeline,


Maybe rename mlpipeline to kubeflow-pipelines or kf-pipelines here and in other places?

we can do a renaming in a dedicated PR. for now it might be better to align with the existing one.

Ark-kun · 2019-05-10T06:26:46Z

experimental/manifests/base/argo/workflow-controller-configmap.yaml

+    {
+    executorImage: argoproj/argoexec:v2.2.0,
+    artifactRepository:
+    {


Is this indent correct and do we need curly braces?

it's just to align with the existing one.

IronPan · 2019-05-13T19:08:34Z

/assign @Liujingfang1

k8s-ci-robot · 2019-05-13T19:08:35Z

@IronPan: GitHub didn't allow me to assign the following users: Liujingfang1.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Liujingfang1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-05-13T19:08:35Z

@IronPan: GitHub didn't allow me to assign the following users: Liujingfang1.

Note that only kubeflow members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Liujingfang1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

IronPan · 2019-05-13T19:09:08Z

/assign @Ark-kun @vicaire

Liujingfang1 · 2019-05-13T19:34:04Z

manifests/README.md

+- Edit [kustomization.yaml](namespaced-install/kustomization.yaml) namespace section to FOO
+- Then run 
+```
+kubectl kustomize . | kubectl create -f -


We don't recommend to use kubectl create. You can use
kubectl kustomize . | kubectl apply -f -
Or
kubectl apply -k .

Or (with Kustomize installed)
kustomize build . | kubectl apply -f -.

great catch.

Liujingfang1 · 2019-05-13T19:35:17Z

manifests/README.md

+
+Or if you deploy using kustomize
+```
+kubectl kustomize . | kubectl delete -f -


Similarly, here you have multiple choices
kubectl kustomize . | kubectl delete -f -
or
kubectl delete -k -
or (with kustomize installed)
kustomize build . | kubectl delete -f -

great good to know. i'll keep it in mirror to the command above, to make it easy to understand.

Liujingfang1 · 2019-05-13T19:36:51Z

manifests/README.md

+kubectl create clusterrolebinding your-binding --clusterrole=cluster-admin --user=[your-user-name]
+```
+
+# Customization


Is there any other customization that user want to perform other than namespace?
If there is, I suggest to add instructions as well.

I'm plan to add it incrementally. want to use this PR as a good baseline.
does that sounds good?

sounds good to me. Feel free to ping me when you add more customization.

Liujingfang1 · 2019-05-13T19:38:11Z

manifests/namespaced-install/kustomization.yaml

+- ml-pipeline-scheduledworkflow-deployment-patch.yaml
+
+vars:
+  - name: NAMESPACE


This is a smart way of keeping the namespace the same as the namespace directive in kustomization.yaml. Good job.

Liujingfang1 · 2019-05-13T19:39:42Z

manifests/README.md

+
+# Customization
+
+## Change deploy namespace


Let's keep the base unchanged. It is recommend to create overlays and add customization in the overlay.

OK I'd picture the base/ dir to be unchanged, and people add overlay if needed. regarding this comment, do you just want me to call this out, or something else i need to do?

Call this out and explain that with all customization in the overlay, it is easy to understand what has been changed.

Liujingfang1 · 2019-05-13T19:43:15Z

manifests/base/argo/workflow-controller-configmap.yaml

@@ -0,0 +1,26 @@
+apiVersion: v1
+kind: ConfigMap


We have configMapGenerator and secretGenerator which can the pods auto pick up the latest configmaps or secrets if they have changed. You can read more info here.

Thanks for the doc. It looks great. Based on the doc it seems gen is optional.
The idea here is to reduce the templating "magic" to minimum and having the spec as close to the plain yaml as possible.
(it was a hard lesson learnt by using ksonnet and forgive me being overly cautious on it :P)

Ark-kun · 2019-05-14T00:46:40Z

/lgtm

IronPan · 2019-05-14T06:20:22Z

/approve

k8s-ci-robot · 2019-05-14T06:20:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [IronPan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2019-05-14T06:20:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [IronPan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

IronPan · 2019-05-14T06:56:50Z

sample tests are flaky.

* go mod tidy * Update k8s libs to 0.19.2, fix issues, and run make tests

…ubeflow#1343) * parent a0a52f8 author Manasvi Tickoo <MTICKOO@bloomberg.net> 1611275174 -0500 committer Manasvi Tickoo <MTICKOO@bloomberg.net> 1612370131 -0500 1159 - cloudevent support ofr kfserving PR comments Fix clpudevent headers Add unit test for cloud event messages Add avro unit test Add avro to kfserving requirements.txt PR comments kfserving check ce-contenttyp before unmarshalling Update k8s libraries to 0.19.2 (kubeflow#1305) * go mod tidy * Update k8s libs to 0.19.2, fix issues, and run make tests * Handle ce to_binary return type wile building resp

stage minimum

cffda7e

k8s-ci-robot added do-not-merge/work-in-progress labels May 9, 2019

k8s-ci-robot requested review from Ark-kun, vicaire and yebrahim May 9, 2019 23:40

k8s-ci-robot added the size/XL label May 9, 2019

Ark-kun reviewed May 10, 2019

View reviewed changes

IronPan added 3 commits May 10, 2019 14:30

update

50ff75c

working example

bb43b61

move code

587e841

k8s-ci-robot added size/XXL and removed size/XL labels May 13, 2019

IronPan added 2 commits May 13, 2019 12:01

remove code

cbac982

update readme

2df54c1

k8s-ci-robot assigned Ark-kun and vicaire May 13, 2019

IronPan changed the title ~~[WIP] kustomize kf pipeline~~ kustomize kf pipeline May 13, 2019

k8s-ci-robot removed do-not-merge/work-in-progress labels May 13, 2019

Liujingfang1 reviewed May 13, 2019

View reviewed changes

address comments

0bea4e7

k8s-ci-robot added the lgtm label May 14, 2019

k8s-ci-robot added the approved label May 14, 2019

IronPan merged commit c3235d7 into master May 14, 2019

IronPan deleted the quickdeploy branch May 30, 2019 07:16

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023

Update k8s libraries to 0.19.2 (kubeflow#1305)

722fec1

* go mod tidy * Update k8s libs to 0.19.2, fix issues, and run make tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kustomize kf pipeline #1305

kustomize kf pipeline #1305

IronPan commented May 9, 2019 •

edited by jlewi

Loading

Ark-kun May 10, 2019

IronPan May 13, 2019

Ark-kun May 10, 2019

IronPan May 13, 2019

IronPan commented May 13, 2019

k8s-ci-robot commented May 13, 2019

k8s-ci-robot commented May 13, 2019

IronPan commented May 13, 2019

Liujingfang1 May 13, 2019

IronPan May 13, 2019

Liujingfang1 May 13, 2019

IronPan May 13, 2019

Liujingfang1 May 13, 2019

IronPan May 13, 2019

Liujingfang1 May 13, 2019

Liujingfang1 May 13, 2019

Liujingfang1 May 13, 2019

IronPan May 13, 2019

Liujingfang1 May 13, 2019

Liujingfang1 May 13, 2019

IronPan May 13, 2019

Ark-kun commented May 14, 2019

IronPan commented May 14, 2019

k8s-ci-robot commented May 14, 2019

k8s-ci-robot commented May 14, 2019

IronPan commented May 14, 2019

kustomize kf pipeline #1305

kustomize kf pipeline #1305

Conversation

IronPan commented May 9, 2019 • edited by jlewi Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IronPan commented May 13, 2019

k8s-ci-robot commented May 13, 2019

k8s-ci-robot commented May 13, 2019

IronPan commented May 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ark-kun commented May 14, 2019

IronPan commented May 14, 2019

k8s-ci-robot commented May 14, 2019

k8s-ci-robot commented May 14, 2019

IronPan commented May 14, 2019

IronPan commented May 9, 2019 •

edited by jlewi

Loading