Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new kubernetes packages contain breaking change, thus fixing the version in the sample test image #1159

Merged
merged 3 commits into from
Apr 15, 2019
Merged

new kubernetes packages contain breaking change, thus fixing the version in the sample test image #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f5afd0
new kubernetes packages contain breaking change, thus fixing the version
gaoning777 Apr 12, 2019
2764b34
also fixing the kubernetes version in the python sdk dependency
gaoning777 Apr 12, 2019
5e6f54f
fix bug
gaoning777 Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/notebooks/KubeFlow Pipeline Using TFX OSS Components.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.5.4rc1"
"version": "3.6.5"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp/compiler/_k8s_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _wait_for_k8s_job(self, pod_name, yaml_spec, timeout):
def _delete_k8s_job(self, pod_name, yaml_spec):
""" _delete_k8s_job deletes a pod """
try:
api_response = self._corev1.delete_namespaced_pod(pod_name, yaml_spec['metadata']['namespace'], k8s_client.V1DeleteOptions())
api_response = self._corev1.delete_namespaced_pod(pod_name, yaml_spec['metadata']['namespace'], body=k8s_client.V1DeleteOptions())
except k8s_client.rest.ApiException as e:
logging.exception('Exception when calling CoreV1Api->delete_namespaced_pod: {}\n'.format(str(e)))

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
'python-dateutil',
'PyYAML',
'google-cloud-storage>=1.13.0',
'kubernetes>=8.0.0',
'kubernetes>=8.0.0, <=9.0.0',
'PyJWT>=1.6.4',
'cryptography>=2.4.2',
'google-auth>=1.6.1',
Expand Down
2 changes: 1 addition & 1 deletion test/sample-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN wget http://central.maven.org/maven2/io/swagger/swagger-codegen-cli/2.4.1/sw

RUN pip3 install wheel
RUN pip3 install junit-xml
RUN pip3 install kubernetes
RUN pip3 install kubernetes==9.0.0
RUN pip3 install minio
RUN pip3 install setuptools==40.5.0
RUN pip3 install papermill==0.16.1
Expand Down