Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependency versions to avoid future breaks #873

Closed
gaoning777 opened this issue Feb 27, 2019 · 4 comments
Closed

Fixing dependency versions to avoid future breaks #873

gaoning777 opened this issue Feb 27, 2019 · 4 comments

Comments

@gaoning777
Copy link
Contributor

We have many breaks recently, be it the components or tests, due to the dependency breaks.
The dependency: dependent software or the base image.
Dependency caused failures: when some dependent software is upgraded, it might've updated its dependency requirement. If new dependency is introduced, our component licenses need to be updated to avoid component image build failure. If the dependency A of the dependency B of our pipeline is upgraded that leads to dependency B failure, our pipeline will also fail. Cases such as these can be enumerated more.

I propose that we pay some efforts now to freeze dependency and base image versions to avoid potential future breaks. I believe this will be a more severe issue as we grow, adding more dependencies to the pipeline system.

I have recently merged two PRs and will send more:
TFDV dependency freeze: #852
Sample test base image freeze: #871

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

/cc @neuromage

As part of this, should we also restore the vendor directory in the repo for GO dependencies?

@neuromage
Copy link
Contributor

@vicaire That won't be necessary. The Go dependencies are already pinned via the go.mod file and the Bazel WORKSPACE file. Both specify the versions of the dependent libraries to use.

If I switch everything to Bazel (including the samples), this will be even better IMO :-)

@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

SG. Thanks @neuromage

@gaoning777
Copy link
Contributor Author

Most of the dependencies are version fixed. We have not seen such problems for quite some time.
Close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants