Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze tfdv dependency #852

Merged
merged 1 commit into from
Feb 23, 2019
Merged

freeze tfdv dependency #852

merged 1 commit into from
Feb 23, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Feb 23, 2019

This change is Reviewable

@gaoning777 gaoning777 changed the title free tfdv dependency freeze freeze tfdv dependency Feb 23, 2019
Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for the change.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit d2f9cc4 into kubeflow:master Feb 23, 2019
@rileyjbauer
Copy link
Contributor

Great! Thank you for doing this!

cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Revert "chore(gcp): migrate to use e2 machines (kubeflow#850)"

This reverts commit 6c5c637.

* fix attempt 2

* fix3
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* New kfserving sample to resolve kubeflow#852

* kubeflow#852 fixing broken links

* kubeflow#853 fixing @yuzisun suggestions

* Update docs/samples/gcp-iap/README.md

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

* kubeflow#853 fixing wrong cert manager port

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* WIP: caching for custom task.

* Extracted cache as a standalone package.

* added go.mod

* fix tests

* feedback

* Added environment variable check, tests and refactored code.

* updated readme

* Apply suggestions from code review

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>

* Update pipelineloop_types.go

Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants