Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample test image build failure #871

Merged
merged 2 commits into from
Feb 27, 2019
Merged

sample test image build failure #871

merged 2 commits into from
Feb 27, 2019

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Feb 27, 2019

lack of python3-dev package in the sample test image.
Reason: google/cloud-sdk base image is updated on Feb 26h, 2019.


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Feb 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 27, 2019
@IronPan
Copy link
Member

IronPan commented Feb 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b3dee05 into kubeflow:master Feb 27, 2019
@gaoning777 gaoning777 deleted the sample-test-image-bug branch February 27, 2019 19:35
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
* sample test image build failure

* fix the base image tag to avoid future breaks
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* Update SDK to support break task as custom task.

* Added tests

* updated testdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants