Skip to content

Conversation

@markwinter
Copy link
Member

@markwinter markwinter commented Nov 3, 2021

Currently it is not possible to edit existing model servers from the web app.

This PR adds a new edit function that lets the users change the existing YAML.
It uses the k8s replace_namespaced_custom_object in the backend.

This will resolve #2 because the user can add the canaryTrafficPercent and change the storageUri

@kimwnasptd Can you review this please?

image

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Mark Winter <mark.winter@navercorp.com>
@markwinter
Copy link
Member Author

/retest

@juliusvonkohout
Copy link
Contributor

@markwinter Please rebase to master

Signed-off-by: Mark Winter <mark.winter@navercorp.com>
@oss-prow-bot
Copy link

oss-prow-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markwinter
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval by writing /assign @juliusvonkohout in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Contributor

Alright then you have to fix the broken tests.

@juliusvonkohout
Copy link
Contributor

Can you rebase to master and fix the tests?

@juliusvonkohout
Copy link
Contributor

closed in favor of #114

juliusvonkohout pushed a commit that referenced this pull request Jun 23, 2025
* feat: added Unit testing using Jest for utils file (#15)

* fix: update import path for Kubeflow styles



* fix: update build scripts to ensure CSS assets are copied correctly



* fix: enhance frontend dependency installation and style setup



* fix: enhance frontend dependency installation and style setup



* fix: enhance frontend dependency installation and style setup



* feat: setup Jest and __mocks__ for unit testing

* feat: enhance type definitions and add tests for predictor extension specifications

* fix: format code for consistency in utils.jest.spec.ts

* fix: update unit test command to use Jest instead of production

---------



* feat: add Cypress support for end-to-end testing and new serve scripts (#16)



---------

Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
Signed-off-by: Harshit Nayan <138717001+LogicalGuy77@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canary Rollout From KF-Serving Web App UI

3 participants