-
Notifications
You must be signed in to change notification settings - Fork 65
Implement editing model servers #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markwinter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
|
/retest |
|
@markwinter Please rebase to master |
Signed-off-by: Mark Winter <mark.winter@navercorp.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: markwinter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Alright then you have to fix the broken tests. |
|
Can you rebase to master and fix the tests? |
|
closed in favor of #114 |
* feat: added Unit testing using Jest for utils file (#15) * fix: update import path for Kubeflow styles * fix: update build scripts to ensure CSS assets are copied correctly * fix: enhance frontend dependency installation and style setup * fix: enhance frontend dependency installation and style setup * fix: enhance frontend dependency installation and style setup * feat: setup Jest and __mocks__ for unit testing * feat: enhance type definitions and add tests for predictor extension specifications * fix: format code for consistency in utils.jest.spec.ts * fix: update unit test command to use Jest instead of production --------- * feat: add Cypress support for end-to-end testing and new serve scripts (#16) --------- Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com> Signed-off-by: Harshit Nayan <138717001+LogicalGuy77@users.noreply.github.com>
Currently it is not possible to edit existing model servers from the web app.
This PR adds a new edit function that lets the users change the existing YAML.
It uses the k8s
replace_namespaced_custom_objectin the backend.This will resolve #2 because the user can add the
canaryTrafficPercentand change thestorageUri@kimwnasptd Can you review this please?