Skip to content

Conversation

@LogicalGuy77
Copy link
Contributor

Description

This PR introduces the ability to edit existing InferenceService configurations directly through the web UI. Users can now modify the YAML definition of a deployed model endpoint.

Currently, users need to use kubectl edit or reapply YAML files via the command line to modify an InferenceService. This feature provides a more user-friendly, integrated way to manage endpoint configurations within the Models Web App itself.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (internal code changes without affecting functionality)
  • Documentation update
  • Build or CI/CD changes
  • Other (please describe):

How Has This Been Tested?

  1. Deployed a sample sklearn InferenceService in the kserve-test namespace.
  2. Navigated to the endpoint details page.
  3. Clicked the "EDIT" button.
  4. Verified the ACE editor loaded with the current InferenceService YAML.
  5. Modified a parameter.
  6. Clicked "Submit".
  7. Verified the success notification appeared.
  8. Verified the UI returned to the details view.
  9. Tested the "Cancel" button functionality.

Screenshots

image

LogicalGuy77 and others added 3 commits April 22, 2025 02:33
* Implement editing model servers (#13)

* Added Model Edit feature

* fix: apply prettier formatting

Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
Co-authored-by: Mark Winter <mark.winter@navercorp.com>
Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
Signed-off-by: LogicalGuy77 <harshitacademia@gmail.com>
@juliusvonkohout
Copy link
Contributor

@Griffin-Sullivan

@juliusvonkohout juliusvonkohout linked an issue Apr 22, 2025 that may be closed by this pull request
@juliusvonkohout juliusvonkohout merged commit 337af9e into kserve:master Apr 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canary Rollout From KF-Serving Web App UI

2 participants