Reworked shell hello world example #2832

rhuss · 2020-09-18T14:27:26Z

Reworked example to be a "true" shell example that is considerabledifferent than the helloworld-go example
Added examples for kn usage

docs/serving/samples/hello-world/helloworld-shell/index.md

docs/serving/samples/hello-world/helloworld-shell/script.sh

googlebot · 2020-09-20T20:56:20Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

docs/serving/samples/hello-world/helloworld-shell/index.md

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

rhuss · 2020-09-25T15:49:48Z

@googlebot I fixed it

googlebot · 2020-09-25T15:51:51Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

maximilien

Nice work. I'll model the ruby example to match this. Left a few comments and typo/fixes to be made.
Otherwise LGTM.

docs/serving/samples/hello-world/helloworld-shell/index.md

maximilien · 2020-09-30T20:28:28Z

docs/serving/samples/hello-world/helloworld-shell/index.md

+- A Kubernetes cluster with Knative installed and DNS configured. Follow the
+  [installation instructions](../../../../install/README.md).
+- [Docker](https://www.docker.com) installed and running on your local machine,
+  and a Docker Hub account configured.


Since Github supports image registry with GitHub Docker packages I wonder if we should also include that here since it keeps everything tidy with GH. Thoughts?

I'd stick with DockerHub for now. If we switch to GHCR we should switch everything, I think.

docs/serving/samples/hello-world/helloworld-shell/index.md

maximilien · 2020-09-30T20:49:28Z

docs/serving/samples/hello-world/helloworld-shell/index.md

+
+   During the creation of your service, Knative performs the following steps:
+
+   - Create a new immutable revision for this version of the app.


Wonder if this should be "Creates" since it really is meant to be: "Knative creates ..." and so on, so "Automatically scales ..."

good question. I haven't added that part, but maybe the gerund form ("Creating") is a better fit ? (as in the next bullet point "programming" is used, but then we should also change to "scaling" in the third item.

@abrennan89 any recommendation ?

"Creation" could be also an option

I moved now to "Creates", "Programs the network" and "scales"

docs/serving/samples/hello-world/helloworld-shell/index.md

rhuss · 2020-10-13T07:50:14Z

@maximilien If we are good with this PR I think it can be merged.

@abrennan89 Maybe you could give this PR a quick look and give if it a lgtm + approve if ok ?

mpetason · 2020-10-14T15:40:23Z

@rhuss I think it is still missing a few updates. It still shows helloworld-go, maybe this is missing a commit?

abrennan89 · 2020-10-14T16:43:27Z

@rhuss is this for 0.19.0, and is there an issue tracking it that you can link?
The jist of the info looks good, but it could use some editing that I won't have time to do this week.

mattmoor · 2020-11-06T04:42:15Z

Generally this LGTM. I'm rebasing my change on this since you fixed the test, and working through the comments now.

Do you want to rebase this, so we can try to land it tomorrow?

rhuss · 2020-11-06T15:28:53Z

Sorry for being later, but as said, I'm think we are good to merge this PR, nothing left from my side. Let me rebase it ...

csantanapr · 2020-11-06T15:30:17Z

/lgtm

csantanapr · 2020-11-06T15:30:57Z

It looks like there is a conflict?

docs/serving/samples/hello-world/helloworld-shell/go.mod

google-cla · 2020-11-06T15:32:56Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mattmoor

/lgtm

knative-prow-robot · 2020-11-06T15:34:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-cla · 2020-11-06T15:41:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

pierDipi · 2020-11-06T15:42:19Z

@googlebot I consent.

…tive#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* Reworked example to be a "true" shell example that is considerable different than the helloworld-go example * Added examples for kn usage (Fixed according to review comments)

pierDipi · 2020-11-06T15:43:06Z

@googlebot I signed it!

mattmoor · 2020-11-06T15:43:56Z

/lgtm

* Change event type in Sequence with Broker example (knative#2897) (knative#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Reworked shell hello world example * Reworked example to be a "true" shell example that is considerable different than the helloworld-go example * Added examples for kn usage (Fixed according to review comments) Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 18, 2020

knative-prow-robot requested review from tcnghia and vagababov September 18, 2020 14:27

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2020

itsmurugappan reviewed Sep 19, 2020

View reviewed changes

docs/serving/samples/hello-world/helloworld-shell/index.md Outdated Show resolved Hide resolved

itsmurugappan reviewed Sep 19, 2020

View reviewed changes

docs/serving/samples/hello-world/helloworld-shell/index.md Outdated Show resolved Hide resolved

itsmurugappan reviewed Sep 19, 2020

View reviewed changes

docs/serving/samples/hello-world/helloworld-shell/index.md Outdated Show resolved Hide resolved

csantanapr reviewed Sep 20, 2020

View reviewed changes

docs/serving/samples/hello-world/helloworld-shell/script.sh Outdated Show resolved Hide resolved

googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 20, 2020

mpetason reviewed Sep 21, 2020

View reviewed changes

docs/serving/samples/hello-world/helloworld-shell/index.md Outdated Show resolved Hide resolved

rhuss mentioned this pull request Sep 25, 2020

Switch helloworld-go with kn #2807

Merged

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2020

mattmoor reviewed Sep 25, 2020

View reviewed changes

rhuss force-pushed the pr/hello-world-shell-tab branch from 55812a7 to 9b29998 Compare September 25, 2020 15:51

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Sep 25, 2020

maximilien suggested changes Sep 30, 2020

View reviewed changes

itsmurugappan mentioned this pull request Oct 9, 2020

hello world java with tabs #2833

Merged

abrennan89 self-assigned this Oct 14, 2020

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2020

maximilien mentioned this pull request Oct 27, 2020

Added examples of kn usage for the PHP sample app #2911

Merged

knative-prow-robot assigned csantanapr Nov 6, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020

rhuss force-pushed the pr/hello-world-shell-tab branch from 9b29998 to 1db3147 Compare November 6, 2020 15:32

knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 6, 2020

google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Nov 6, 2020

mattmoor approved these changes Nov 6, 2020

View reviewed changes

knative-prow-robot assigned mattmoor Nov 6, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020

knative-prow-robot added the approved label Nov 6, 2020

rhuss force-pushed the pr/hello-world-shell-tab branch from 1db3147 to a1726ab Compare November 6, 2020 15:41

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020

pierDipi and others added 2 commits November 6, 2020 16:42

Reworked shell hello world example

39915a6

* Reworked example to be a "true" shell example that is considerable different than the helloworld-go example * Added examples for kn usage (Fixed according to review comments)

rhuss force-pushed the pr/hello-world-shell-tab branch from a1726ab to 39915a6 Compare November 6, 2020 15:43

google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Nov 6, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020

knative-prow-robot merged commit c14f768 into knative:master Nov 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reworked shell hello world example #2832

Reworked shell hello world example #2832

rhuss commented Sep 18, 2020

googlebot commented Sep 20, 2020

mattmoor left a comment

rhuss commented Sep 25, 2020

googlebot commented Sep 25, 2020

maximilien left a comment

maximilien Sep 30, 2020

mattmoor Nov 6, 2020

maximilien Sep 30, 2020

rhuss Oct 13, 2020

rhuss Oct 13, 2020

rhuss Oct 13, 2020

rhuss commented Oct 13, 2020

mpetason commented Oct 14, 2020

abrennan89 commented Oct 14, 2020

mattmoor commented Nov 6, 2020

rhuss commented Nov 6, 2020

csantanapr commented Nov 6, 2020

csantanapr commented Nov 6, 2020

google-cla bot commented Nov 6, 2020

mattmoor left a comment

knative-prow-robot commented Nov 6, 2020

google-cla bot commented Nov 6, 2020

pierDipi commented Nov 6, 2020

pierDipi commented Nov 6, 2020

mattmoor commented Nov 6, 2020


		During the creation of your service, Knative performs the following steps:

		- Create a new immutable revision for this version of the app.

Reworked shell hello world example #2832

Reworked shell hello world example #2832

Conversation

rhuss commented Sep 18, 2020

googlebot commented Sep 20, 2020

mattmoor left a comment

Choose a reason for hiding this comment

rhuss commented Sep 25, 2020

googlebot commented Sep 25, 2020

maximilien left a comment

Choose a reason for hiding this comment

maximilien Sep 30, 2020

Choose a reason for hiding this comment

mattmoor Nov 6, 2020

Choose a reason for hiding this comment

maximilien Sep 30, 2020

Choose a reason for hiding this comment

rhuss Oct 13, 2020

Choose a reason for hiding this comment

rhuss Oct 13, 2020

Choose a reason for hiding this comment

rhuss Oct 13, 2020

Choose a reason for hiding this comment

rhuss commented Oct 13, 2020

mpetason commented Oct 14, 2020

abrennan89 commented Oct 14, 2020

mattmoor commented Nov 6, 2020

rhuss commented Nov 6, 2020

csantanapr commented Nov 6, 2020

csantanapr commented Nov 6, 2020

google-cla bot commented Nov 6, 2020

mattmoor left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Nov 6, 2020

google-cla bot commented Nov 6, 2020

pierDipi commented Nov 6, 2020

pierDipi commented Nov 6, 2020

mattmoor commented Nov 6, 2020