Change event type in Sequence with Broker example #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
|
@pierDipi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/XS
|
/cc @abrennan89 @mpetason |
|
I cannot add |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abrennan89 I think it would be interesting to set up an action for this, but I'm reluctant to try and build it until knative/community#298 makes some progress. |
/retest |
pierDipi
added a commit
to pierDipi/docs-1
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
added a commit
to pierDipi/docs-1
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
added a commit
to pierDipi/docs-1
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes #2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes #2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Oct 8, 2020
If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes #2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
rhuss
pushed a commit
to rhuss/docs
that referenced
this pull request
Nov 6, 2020
…tive#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
rhuss
pushed a commit
to rhuss/docs
that referenced
this pull request
Nov 6, 2020
…tive#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
pushed a commit
that referenced
this pull request
Nov 6, 2020
* Change event type in Sequence with Broker example (#2897) (#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes #2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Reworked shell hello world example * Reworked example to be a "true" shell example that is considerable different than the helloworld-go example * Added examples for kn usage (Fixed according to review comments) Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
RichieEscarez
pushed a commit
to RichieEscarez/docs
that referenced
this pull request
Mar 6, 2021
* Change event type in Sequence with Broker example (knative#2897) (knative#2916) If the type of the event isn't changed by the last step in the sequence the event will be resent to the Trigger that targets the sequence creating an unwanted loop. Fixes knative#2851 Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Reworked shell hello world example * Reworked example to be a "true" shell example that is considerable different than the helloworld-go example * Added examples for kn usage (Fixed according to review comments) Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the event's type isn't changed by the last step in the
sequence the event will be resent to the Trigger that targets
the sequence creating an unwanted loop.
Fixes #2851
Proposed Changes
/label cherrypick-0.18
/label cherrypick-0.17
/label cherrypick-0.16