Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello world java with tabs #2833

Merged
merged 6 commits into from
Nov 4, 2020
Merged

hello world java with tabs #2833

merged 6 commits into from
Nov 4, 2020

Conversation

itsmurugappan
Copy link
Contributor

Proposed Changes

  • hello world java example with tabs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 19, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2020
maximilien
maximilien approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximilien
Copy link
Contributor

/test pull-knative-docs-unit-tests

@tcnghia
Copy link
Contributor

tcnghia commented Oct 8, 2020 •
edited
Loading 

=== RUN   TestDocSrc/java-spring     sampleconsistency_test.go:97: README.md file is missing line 0 ('package com.example.helloworld;') from file '../../docs/serving/samples/hello-world/helloworld-java-spring/src/main/java/com/example/helloworld/HelloworldApplication.java'         Additional info:         All files required for running sample apps are checked against README.md, the content of source files should be identical with what's in README.md file, the list of the files to be verified is the same set of files used for running sample apps, they are configured in `/test/sampleapp/config.yaml`. If an exception is needed the file can be configured to be copied as a separate step in `PreCommand` such as: https://github.com/knative/docs/blob/65f7b402fee7f94dfbd9e4512ef3beed7b85de66/test/sampleapp/config.yaml#L4     --- FAIL: TestDocSrc/java-spring (0.00s) | === RUN   TestDocSrc/java-spring     sampleconsistency_test.go:97: README.md file is missing line 0 ('package com.example.helloworld;') from file '../../docs/serving/samples/hello-world/helloworld-java-spring/src/main/java/com/example/helloworld/HelloworldApplication.java'         Additional info:         All files required for running sample apps are checked against README.md, the content of source files should be identical with what's in README.md file, the list of the files to be verified is the same set of files used for running sample apps, they are configured in `/test/sampleapp/config.yaml`. If an exception is needed the file can be configured to be copied as a separate step in `PreCommand` such as: https://github.com/knative/docs/blob/65f7b402fee7f94dfbd9e4512ef3beed7b85de66/test/sampleapp/config.yaml#L4

@itsmurugappan
Copy link
Contributor Author

pr takes care of this test failure, once that is merged , i can rebase which will fix the test

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2020
abrennan89
abrennan89 suggested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@abrennan89 abrennan89 self-assigned this Nov 3, 2020
@abrennan89 abrennan89 added this to the v0.19.0 milestone Nov 3, 2020
@abrennan89
Copy link
Contributor

pr takes care of this test failure, once that is merged , i can rebase which will fix the test

@itsmurugappan Thanks for the updates! Do we have a dependency on merging #2832 first, or is this PR ready to merge now?
@rhuss can you take a look at that PR please, it looks like it needs a rebase.

@abrennan89 abrennan89 self-requested a review November 4, 2020 18:12
abrennan89
abrennan89 approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/approve
/lgtm

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, itsmurugappan, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsmurugappan
Copy link
Contributor Author

This can be merged now as I have fixed the Readme to pass the tests.

@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2020
@abrennan89
Copy link
Contributor

Thanks @itsmurugappan - does this need to be cherry-picked to any older branches?

@knative-prow-robot knative-prow-robot merged commit 656d260 into knative:master Nov 4, 2020
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 6, 2021
@itsmurugappan @RichieEscarez
hello world java with tabs (knative#2833)
33ac6ea 
* rewrite hello world java with tabs

* rewrite hello world java with tabs

* rewrite hello world java with tabs

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetason mpetason mpetason left review comments

@maximilien maximilien maximilien approved these changes

@abrennan89 abrennan89 abrennan89 approved these changes

@tcnghia tcnghia Awaiting requested review from tcnghia

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@abrennan89 abrennan89

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
7 participants
@itsmurugappan @maximilien @tcnghia @abrennan89 @knative-prow-robot @mpetason @googlebot