Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude the numpy backend when reporting coverages #12493

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Exclude the numpy backend when reporting coverages #12493

merged 1 commit into from
Mar 17, 2019

Conversation

taehoonlee
Copy link
Contributor

Summary

This PR excludes he numpy backend when reporting coverages. This affects only calculating test coverages.

Related Issues

#10802
#10801
#9942
#9568
#9223

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@taehoonlee
Copy link
Contributor Author

The results are:

Before After
Python 3.6 + TF 91.46% 91.38%
Python 3.6 + TH 89.25% 89.25%
Python 3.6 + C 88.65% 88.74%

@fchollet fchollet merged commit c82fe8a into keras-team:master Mar 17, 2019
@taehoonlee taehoonlee deleted the numpy_coverage branch March 17, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taehoonlee @fchollet