Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Theano legacy functions when reporting coverages #10801

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Exclude Theano legacy functions when reporting coverages #10801

merged 1 commit into from
Jul 30, 2018

Conversation

taehoonlee
Copy link
Contributor

This PR excludes Theano legacy functions when reporting coverages. This affects only calculating test coverages.

@taehoonlee taehoonlee force-pushed the exclude_legacy_for_coverage branch from 201e9be to 75742d7 Compare July 30, 2018 05:43
@taehoonlee
Copy link
Contributor Author

The results are:

Before After
Python 2.7 + C 88.41% 88.91%
Python 3.5 + C 88.37% 88.88% 
(before) keras/backend/theano_backend.py            1312    146    89%
(after) keras/backend/theano_backend.py            1250     86    93%

@fchollet fchollet merged commit 93cd240 into keras-team:master Jul 30, 2018
@taehoonlee taehoonlee deleted the exclude_legacy_for_coverage branch July 31, 2018 01:37
This was referenced Mar 15, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taehoonlee @fchollet