Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude CNTK legacy codes when reporting coverages #10802

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Exclude CNTK legacy codes when reporting coverages #10802

merged 1 commit into from
Jul 30, 2018

Conversation

taehoonlee
Copy link
Contributor

This PR excludes CNTK legacy codes when reporting coverages (the _padding is for the old versions that don't have C.pad). This affects only calculating test coverages.

@taehoonlee taehoonlee force-pushed the exclude_cntk_legacy_for_coverage branch from 424d15d to b45a05d Compare July 30, 2018 05:43
@taehoonlee
Copy link
Contributor Author

The results are:

Before After
Python 2.7 + C 88.26% 88.41%
Python 3.5 + C 88.23% 88.38% 
(before) keras/backend/cntk_backend.py              1454    161    89%
(after) keras/backend/cntk_backend.py              1435    143    90%

@fchollet fchollet merged commit 2038481 into keras-team:master Jul 30, 2018
@taehoonlee taehoonlee deleted the exclude_cntk_legacy_for_coverage branch July 31, 2018 01:38
This was referenced Mar 15, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taehoonlee @fchollet