-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of scripts with entry_points #237
Replace use of scripts with entry_points #237
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'm not so confident on this technically etc so I'll ping someone else for review as well.
@minrk and @rkdarst I saw that this project isn't getting so much maintainer attention and hoped to ensure a few simpler PRs at least got some attention. As I'm not an active user myself so I only dare merge things that seems very clear to not break something, perhaps you could have a look at this small PR?
Here's the corresponding PR on jupyterhub itself: |
Nice that makes me quite confident this is good to go, I'll go for a merge if this grows stale. Btw, test failures are unrelated and fixed by #241. |
Given that this pattern was demonstrated sensible in jupyterhub without other changes needed and the PR seemed to go stale I'll go for a merge on this now that also all tests has passed by fixing it in other PRs. |
References
scripts
withconsole_scripts
#235Changes
scripts
withentry_points: console_scripts