Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scripts with console_scripts #235

Closed
nrbgt opened this issue Apr 4, 2022 · 1 comment · Fixed by #237
Closed

Replace scripts with console_scripts #235

nrbgt opened this issue Apr 4, 2022 · 1 comment · Fixed by #237

Comments

@nrbgt
Copy link

nrbgt commented Apr 4, 2022

Proposed change

While this package doesn't require being entirely cross-platform, use of scripts is more portable and better managed on different downstreams.

Alternative options

Keep using scripts.

Who would use this feature?

Downstream packagers, such as conda-forge can reason

(Optional): Suggest a solution

Likely, need to

  • replace
    • scripts="scripts=glob(pjoin("scripts", "*")) with
    • entry_points=dict(console_scripts=["batchspawner-singleuser=batchspawner.singleuser:main"])
  • delete scripts/ (and any references in other files, etc)
@welcome
Copy link

welcome bot commented Apr 4, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

consideRatio added a commit that referenced this issue Apr 14, 2022
Replace use of scripts with entry_points
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant