Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump pre-commit black to stable #238

Merged
merged 1 commit into from
Apr 6, 2022
Merged

bump pre-commit black to stable #238

merged 1 commit into from
Apr 6, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Apr 5, 2022

References

Changes

  • bumps to stable black
    • this version is compatible with the unmanaged transient dependencies (click, etc) that pre-commit brings along

consideRatio
consideRatio approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, should be fine to merge even though there are unrelated CI failures.

@consideRatio consideRatio merged commit 23d4633 into jupyterhub:master Apr 6, 2022
@welcome
Copy link

welcome bot commented Apr 6, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio consideRatio mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @consideRatio