Automatically disable raw mode for non-tty #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change automatically disables raw mode when not connected to a terminal. This seems to be a more useful default, which allows to redirect input from a file, e.g., at a CI. Things will just work.
|
@certik I fixed the test on this one. The previous expected failure seems to work fine now. |
|
Yeah, this is related to #59, we need robust testing of the interactive prompt. |
|
Hey @certik, wanted to quickly ask what the problem was with this PR. I have seen that (along with other things) in the code and would like to make those extra features available as well for the completeness. Also We should discuss how the input is handled anyway as the input function is not associated with the Terminal class anymore - so the input function is not aware of wether raw input is available or not. We should do that after the prompt is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change automatically disables raw mode when not connected to a
terminal. This seems to be a more useful default, which allows to
redirect input from a file, e.g., at a CI. Things will just work.