Skip to content

Automatically disable raw mode for non-tty #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Automatically disable raw mode for non-tty #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed8bece
Automatically disable raw mode for non-tty
certik Oct 20, 2020
2920440
update test
wolfv Oct 21, 2020
021e1a3
still doesnt succeed for OS X
wolfv Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp-terminal/terminal_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ class BaseTerminal {
BaseTerminal(bool enable_keyboard=false, bool /*disable_ctrl_c*/ = true)
: keyboard_enabled{enable_keyboard}
{
// Uncomment this to silently disable raw mode for non-tty
//if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
// Silently disable raw mode for non-tty
if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
out_console = is_stdout_a_tty();
if (out_console) {
hout = GetStdHandle(STD_OUTPUT_HANDLE);
Expand Down Expand Up @@ -113,8 +113,8 @@ class BaseTerminal {
BaseTerminal(bool enable_keyboard=false, bool disable_ctrl_c=true)
: keyboard_enabled{enable_keyboard}
{
// Uncomment this to silently disable raw mode for non-tty
//if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
// Silently disable raw mode for non-tty
if (keyboard_enabled) keyboard_enabled = is_stdin_a_tty();
if (keyboard_enabled) {
if (tcgetattr(STDIN_FILENO, &orig_termios) == -1) {
throw std::runtime_error("tcgetattr() failed");
Expand Down
7 changes: 5 additions & 2 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ examples/colors

echo "Expected to succeed:"
examples/colors < README.md
echo "Expected to fail"
echo "Expected to succeed:"
set +e
examples/keys < README.md
if [[ $? != 0 ]]; then

uname=`uname`

if [[ $? == 0 -and $uname == "Linux" ]]; then
echo "Success"
else
echo "Fail"
Expand Down