added functions for reading stdin #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 25, 2022
Closed
|
Hey @certik can you review this change? I took the stdin reading from the input function and changed it into a function that reads the full stdin as a file. Also the windows test succeeded before, because the path the script entered was incorrect but not catched as an error. Also I'm not sure installing a shared library on windows is even possible, because visual studio is not supporting that. Do you have a clue on that? I have removed the windows test for now so that the CI works again |
|
@certik I'll merge this now, please open an issue if you need changes on the stdin handling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the part of the
raw_input()functions into it's own function to allow the user to get the stdin input as string. This PR also features comment improvements for all input functions to note things like what happens whenTerm::Terminalis not enabling the input.