Merge in from upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"mac set ch status XX on" needs to be done last. Especially after "mac set ch dcycle", otherwise the channel stays off. This commit changes the order of the configuration code to fix this.
* implemented the code from tweetonig: defines for the MAC command deleted the sendcommand. Removed all Strings replaced them by char * with additional functions. There are some small issues with the char * integration I didn't fix yet. Repalced readValue by sendGetData. Replaced hard message by defines. Changed place of mac defines to cpp file and fix mac set rx2 * fixed compareString * Update API ref for TheThingsNetwork * fix defines
Protocol Buffer(nanopb) Receive example
…e of the buffer in the encodeSensorData() fixed it for the moment trying to find a solution with this (#136)
replace Serial1 by modemStream
* fixed compiling issues with platformio CI it works but will change subString function in other PR * re-enabled the CI test
… compareString to flash memory (#144)
Use Arduino CLI for CI
Each field of keywords.txt is separated by a single true tab. When you use multiple tabs it causes the field to be interpreted as empty. On Arduino IDE 1.6.5 and newer an empty KEYWORD_TOKENTYPE causes the default editor.function.style coloration to be used (as with KEYWORD2, KEYWORD3, LITERAL2). On Arduino IDE 1.6.4 and older it causes the keyword to not be recognized for any special coloration. Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
Use a single tab field separator in keywords.txt
The ABP and OTAA examples links were no longer correct, also replaced all absolute Github URLs with relative ones so they work as expected in forked or offline repositories.
Fix TheThingsMessage documentation links
Fix for compiling on ESP32
Fix regression for Arduino SAMD boards
Improved the documentation to mitigate confusion that showed in https://www.thethingsnetwork.org/forum/t/ttn-node-link-check-does-not-work/19981/18 - Calling `linkCheck` before joining has no effect. - The `linkCheck` command is delegated to the RN2483 module by using `mac set linkchk`, which [is documented as](http://ww1.microchip.com/downloads/en/DeviceDoc/40001784C.pdf#page=29): > When the time interval expires, the next application packet that will be sent to the server will include also a link check MAC command.
Enhanced documentation for linkCheck()
* Adding attempts to readLine and state marker if radio module is unresponsive * Fix spacing around brackets * Adding attempts to TheTHingsNetwork.h * No need for else when if has return * Set default in header file * decrement attempts * Proposal to handle exception when RN module does not respond * Changed variable name from radioModuleInvalidState to needsHardReset * Added hardReset function with non-blocking delay. made needsHardReset a public variable * Updating documentation for hardreset * Changed wording of unresponsive rn module in readline function * Spacing in if statement in readline function * Removing comment at readline function * Fixed spelling mistake of millis in resetHard * Replacing single qoute with double qoute to fix warning: character constant too long for its type * remove empty line * Fixed missing ( * moved adr parameter to reset and added parameter description for hardreset * Spelling mistake * Reformulated the non i/o blocking wait function to make it more understandable * Updated the way while brackets are placed in resetHard * Updated hardreset documentation to include initial pinmode setup * rewording of hardreset output pin config * Using delay(1000) instead of custom delay function to ensure that ESP8266 background operations will work
Fix links to Uno and Node
Avoid compiler warning
Fix `readLine`'s `needsHardReset` condition
pb.h should be included from the local directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.