Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid compiler warning #250

Merged
merged 2 commits into from
Jan 27, 2019
Merged

Conversation

AmedeeBulle
Copy link
Contributor

This is more cosmetic than anything else, but I try to avoid unnecessary compiler warnings in builds.
The unused attributes acknowledges the variable is unused and suppress the warning.

Alternatively we could cast readResponse() to (void) instead of using the length variable...

@johanstokking
Copy link
Member

Thanks!

How about not declaring size_t length in the first place?

@AmedeeBulle
Copy link
Contributor Author

That's the alternative I was suggesting as well...

Updated the MR.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanstokking johanstokking merged commit 3164696 into TheThingsNetwork:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants