Fix TheThingsMessage documentation links #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cimm
force-pushed
the
fix-thethingsmessage-doc-urls
branch
from
c27ddda
to
962884a
Compare
johanstokking
requested changes
Jul 19, 2018
docs/TheThingsNetwork.md
Outdated
| @@ -64,7 +64,7 @@ RX Delay 1: 1000 | |||
| RX Delay 2: 2000 | |||
| ``` | |||
|
|
|||
| See the [DeviceInfo](https://github.com/TheThingsNetwork/arduino-device-lib/blob/master/examples/DeviceInfo/DeviceInfo.ino) example. | |||
| See the [DeviceInfo](../examples/DeviceInfo/DeviceInfo.ino) example. | |||
There was a problem hiding this comment.
Please leave the absolute paths; we're also importing this Markdown in external documentation that are unable to handle the relative path.
There was a problem hiding this comment.
Thanks for the feedback. I reverted the relative URLs to the absolute Github ones.
The ABP and OTAA examples links were no longer correct, also replaced all absolute Github URLs with relative ones so they work as expected in forked or offline repositories.
cimm
force-pushed
the
fix-thethingsmessage-doc-urls
branch
from
962884a
to
edf1e67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed 2 broken links in the TheThingsNetwork documentation. The links to the
Send.inoandABP.inoexamples are broken. It looks like the filenames changed. I fixed those.Also changed the absolute URLs to relative ones since the absolute links would point to the TheThingsNetwork repository even if you are on a forked or offline repository.
Tiny changes.