[postgresql] - remove notice from manage database

[alikon]

Pull Request for Issue #14331 .

Summary of Changes

managed DROP DEFAULT on JSchemaChangeitem for postgresql

Testing Instructions

With latest staging on postgresql go to Manage > Database.

Expected result

no notice

Actual result

Notice: Undefined offset:

[waader]

I have tested this item ✅ successfully on 2e35e03

Thanks alikon!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14423.}

[csthomas]

IMO this is the wrong solution. We can not remove DROP DEFAULT from update files.

We have to fix php code in https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/schema/changeitem/postgresql.php#L132
I suppose that reverse the order of elseif
with
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/schema/changeitem/postgresql.php#L111
would solve the problem.

[alikon]

could be i've checked rather quickly,
but why

We can not remove DROP DEFAULT from update files.

[csthomas]

• because drop default - in general this is not a solution but only temporary fix, we do not want to remove all "DROP DEFAULT ..." from sql updates files.
• because other databases does not have default too
• because bug is in the file mentioned by me earlier, not in sql updates files.

[alikon]

i've just looked at #__contact_details and
ALTER TABLE "#__contact_details" ALTER COLUMN "name" DROP DEFAULT;
even if for me is not needed (DROP DEFAULT) , i agree with you should be correctly managed by changeitem for postgresql

[waader]

I have tested this item ✅ successfully on 0aae960

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14423.}

[alikon]

conflict fixed in #18483