[postgresql] - schema change rework #18483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conflict fix dued to namespace
ALTER TABLE "#__extensions" ALTER COLUMN "custom_data" DROP NOT NULL;
ALTER TABLE "#__extensions" ALTER COLUMN "custom_data" SET DEFAULT '';then joomla does not see any problems, but should show that
|
return a row only when the column have a default
|
1 and 2 fixed |
alikon
changed the title
|
reworked a little bit for use |
Quy
reviewed
Jan 2, 2018
| . ' ELSE ' | ||
| . ' substring(column_default, 1, (position('. $this->db->quote('::') . ' in column_default) -1)) = ' . $this->db->quote($string) | ||
| . ' END)'; | ||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 2, 2018
| $result = 'SELECT column_name, data_type, is_nullable , column_default FROM information_schema.columns' | ||
| . ' WHERE table_name=' . $this->fixQuote($wordArray[2]) . ' AND column_name=' . $this->fixQuote($wordArray[5]) | ||
| . ' AND is_nullable = ' . $isNullable; | ||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 2, 2018
| } | ||
| else | ||
| break; | ||
| case 'SET' : |
Quy
reviewed
Jan 2, 2018
| . ' AND data_type=' . $this->fixQuote($type); | ||
| $result = 'SELECT column_name, data_type FROM information_schema.columns WHERE table_name=' | ||
| . $this->fixQuote($wordArray[2]) . ' AND column_name=' . $this->fixQuote($wordArray[5]) | ||
| . ' AND data_type=' . $this->fixQuote($type); | ||
|
|
||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 2, 2018
| } | ||
| else | ||
| break; | ||
|
|
|
@Quy hope cs better now |
Quy
reviewed
Jan 3, 2018
| $this->queryType = 'CHANGE_COLUMN_TYPE'; | ||
| $this->msgElements = array($this->fixQuote($wordArray[2]), $this->fixQuote($wordArray[5]), $type); | ||
| break; | ||
| case 'SET' : |
There was a problem hiding this comment.
Add a blank line before line 115.
Quy
reviewed
Jan 3, 2018
| $this->checkQueryExpected = 0; | ||
| $this->msgElements = array($this->fixQuote($wordArray[2]), $this->fixQuote($wordArray[5]), 'NOT NULL'); | ||
| } | ||
| break; |
There was a problem hiding this comment.
I think it is missing closing } to the switch statement.
Quy
reviewed
Jan 3, 2018
| . ' ELSE ' | ||
| . ' substring(column_default, 1, (position('. $this->db->quote('::') . ' in column_default) -1)) = ' . $this->db->quote($string) | ||
| . ' END)'; | ||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 3, 2018
| $result = 'SELECT column_name, data_type, is_nullable , column_default FROM information_schema.columns' | ||
| . ' WHERE table_name=' . $this->fixQuote($wordArray[2]) . ' AND column_name=' . $this->fixQuote($wordArray[5]) | ||
| . ' AND column_default IS NULL'; | ||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 3, 2018
| $result = 'SELECT column_name, data_type, is_nullable , column_default FROM information_schema.columns' | ||
| . ' WHERE table_name=' . $this->fixQuote($wordArray[2]) . ' AND column_name=' . $this->fixQuote($wordArray[5]) | ||
| . ' AND is_nullable = ' . $isNullable; | ||
| $this->queryType = 'CHANGE_COLUMN_TYPE'; |
Quy
reviewed
Jan 3, 2018
| . $this->fixQuote($wordArray[2]) . ' AND column_name=' . $this->fixQuote($wordArray[5]) | ||
| . ' AND (CASE (position(' . $this->db->quote('::') . ' in column_default))' | ||
| . ' WHEN 0 THEN ' | ||
| . ' column_default = ' . $this->db->quote($string) |
|
sorry & thanks @Quy for your extra-work still fighting with the local setup of phpcs 🤕 |
|
please test #19707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #14331 and porting of #17351.
Summary of Changes
support these schema changes:
ALTER TABLE "#__table" ALTER COLUMN "field" SET NOT NULL;ALTER TABLE "#__table" ALTER COLUMN "field" SET DEFAULT value;ALTER TABLE "#__table" ALTER COLUMN "field" DROP DEFAULT;ALTER TABLE "#__table" ALTER COLUMN "field" DROP NOT NULL;Testing Instructions
With latest staging on postgresql go to Manage > Database.
Expected result
no notice
Actual result
Notice: Undefined offset:....
@waader , @csthomas please re-test, review