Use importlib.metadata to get package version instead of pkg_resources.get_distribution to decrease memory consumption #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion instead of pkg_resources.get_dictribution
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 9 9
Lines 632 636 +4
=======================================
+ Hits 630 634 +4
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thank you for the PR! I agree, let's remove However, let's use the Please could you update the PR? |
|
Done. |
|
Thanks, please can you move it to Something like: [options]
install_requires =
importlib-metadata;python_version < '3.8' |
hugovk
changed the title
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources use a lot of memory and after introducing importlib.metadata in 3.8 looks obsolete. So let's change way to get package version and get rid of pkg_resources import.