switch from setuptools/pkg_resources to importlib.metadata #180
Conversation
graingert
force-pushed
the
importlib-metadata
branch
from
45e0478
to
168589d
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 569 572 +3
=========================================
+ Hits 569 572 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
setup.cfg
Outdated
| @@ -56,7 +56,7 @@ max_line_length = 88 | |||
| convention = google | |||
|
|
|||
| [tool:isort] | |||
There was a problem hiding this comment.
Please could you replace all these isort settings with profile = "black" and move it into pyproject.toml?
There was a problem hiding this comment.
moved all the configs I can into pyproject.toml
pyproject.toml
Outdated
|
|
||
| [pytest] | ||
| addopts = --doctest-modules |
There was a problem hiding this comment.
| [pytest] | |
| addopts = --doctest-modules |
pyproject.toml
Outdated
| [tool.pytest.ini_options] | ||
| addopts = "--color=yes" |
There was a problem hiding this comment.
| [tool.pytest.ini_options] | |
| addopts = "--color=yes" | |
| [tool.pytest.ini_options] | |
| addopts = "--strict-config --strict-markers --color=yes --doctest-modules" | |
| xfail_strict = true | |
| junit_family = "xunit2" | |
| filterwarnings = ["error"] |
graingert
force-pushed
the
importlib-metadata
branch
from
ff0cf66
to
45f773a
Compare
pyproject.toml
Outdated
| [tool.pytest.ini_options] | ||
| addopts = "--color=yes --doctest-modules" |
There was a problem hiding this comment.
| [tool.pytest.ini_options] | |
| addopts = "--color=yes --doctest-modules" | |
| [tool.pytest.ini_options] | |
| addopts = "--strict-config --strict-markers --color=yes --doctest-modules" | |
| xfail_strict = true | |
| junit_family = "xunit2" | |
| filterwarnings = ["error"] |
There was a problem hiding this comment.
@hugovk do you want --color=yes enabled? it was in setup.cfg where it was ignored in favour of the config in tox.ini
There was a problem hiding this comment.
As long as we get coloured pytest output on GitHub Actions, it's fine to keep it in just one place.
Although please could we keep the tox.ini file? I'd prefer to keep that stuff in there because it's easier to look for and more common to have the test commands in there.
(pytest config can come here.)
Thanks!
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
```
n = 7.0
def _as_int(n):
try:
i = round(n)
except TypeError:
raise TypeError('Plural value must be an integer, got %s' %
(n.__class__.__name__,)) from None
import warnings
> warnings.warn('Plural value must be an integer, got %s' %
(n.__class__.__name__,),
DeprecationWarning, 4)
E DeprecationWarning: Plural value must be an integer, got float
/usr/lib/python3.9/gettext.py:170: DeprecationWarning
```
black is already configured in pyproject.toml
graingert
force-pushed
the
importlib-metadata
branch
from
9aafb31
to
699b3eb
Compare
|
@hugovk I think if you're going to have black/isort/pytest config in pyproject.toml you might as well put tox config in there too |
|
Done in #227. Thanks! |
Changes proposed in this pull request: