Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant setuptools from install_requires #232

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Remove redundant setuptools from install_requires #232

merged 1 commit into from
Oct 7, 2021

Conversation

arthurzam
Copy link
Contributor

The setuptools install requires was added as of commit a3e0fd8 for pkg_resources.
But after #227 was merged, pkg_resources isn't used at all, so as a result setuptools can be removed from install requires.

@arthurzam
remove setuptools install requires
4202e87 
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@hugovk hugovk added changelog: Changed For changes in existing functionality hacktoberfest-accepted To credit accepted Hacktoberfest PRs labels Oct 7, 2021
@hugovk hugovk changed the title remove setuptools install requires Remove redundant setuptools from install_requires Oct 7, 2021
@hugovk hugovk merged commit 77a1897 into jmoiron:master Oct 7, 2021
@hugovk
Copy link
Collaborator

hugovk commented Oct 7, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Changed For changes in existing functionality hacktoberfest-accepted To credit accepted Hacktoberfest PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurzam @hugovk