merge rrule-alt #196
Merged
merge rrule-alt #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
arolson101
commented
Feb 14, 2018
arolson101
commented
- updated dependencies
- fixed problems with updated standard
- add typescript definitions
- added a couple tests (testConvertAndBack, testByHourValues)
- changed ORDINAL_BASE to 1900 (AFAICT it can be 1, but not willing to do that right now)
- changed version to 2.2.8 to match rrule-alt so that it's clear that rrule is ahead
#125 note: I didn’t take the tests because they are supposed to fail, and there’s no existing convention to test that errors are thrown
#125 note: I didn’t take the tests because they are supposed to fail, and there’s no existing convention to test that errors are thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.