Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VALUE=DATE as a RDATE param #128

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

tchap
Copy link
Contributor

@tchap tchap commented Feb 2, 2016

I checked other functions and it seems to me that simply allowing VALUE=DATE will work since the time part is optional in the parsing function.

References #127

@http-teapot
Copy link
Collaborator

http-teapot commented Jan 5, 2018

It'd be great if this PR could be merged.

const r = [
  "EXDATE;VALUE=DATE:20150610",
  "RDATE;VALUE=DATE:20150609,20150611",
  "RRULE:FREQ=DAILY;UNTIL=20150628;INTERVAL=3"
];
rrulestr(r); // unsupported RDATE parm: VALUE=DATE

const r = [
  "EXDATE;VALUE=DATE-TIME:20150610", // using DATE-TIME instead
  "RDATE;VALUE=DATE-TIME:20150609,20150611", // using DATE-TIME instead
  "RRULE:FREQ=DAILY;UNTIL=20150628;INTERVAL=3"
];
rrulestr(r); // succeed, though it appends time to date which isn't critical at all

@espen
Copy link
Collaborator

espen commented Jan 16, 2018

Can you add some tests for this?

@arolson101 arolson101 merged commit ebca44b into jkbrzt:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants