Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bug" in _iter-function #135

Closed
mark-spencer opened this issue Mar 11, 2016 · 2 comments
Closed

"Bug" in _iter-function #135

mark-spencer opened this issue Mar 11, 2016 · 2 comments
Labels

Comments

@mark-spencer
Copy link

Extract from _iter function:

var timeset
            if (freq < RRule.HOURLY) {
                timeset = this.timeset
            } else {
                var gettimeset = {}
                gettimeset[RRule.HOURLY] = ii.htimeset
                gettimeset[RRule.MINUTELY] = ii.mtimeset
                gettimeset[RRule.SECONDLY] = ii.stimeset
                gettimeset = gettimeset[freq]
                if ((freq >= RRule.HOURLY && plb(byhour) && !contains(byhour, hour)) || 
                (freq >= RRule.MINUTELY && plb(byminute) && !contains(byminute, minute)) || 
                (freq >= RRule.SECONDLY && plb(bysecond) && !contains(bysecond, minute))) {
                    timeset = []
                } else {
                    timeset = gettimeset.call(ii, hour, minute, second, dtstartMillisecondModulo)
                }
            }

There seems to be an error at this line:

(freq >= RRule.SECONDLY && plb(bysecond) && !contains(bysecond, minute))) {

Should the minute not be second?

@mark-spencer mark-spencer changed the title Bug in _iter-function "Bug" in _iter-function Mar 11, 2016
@arolson101
Copy link
Collaborator

The tests pass with it either way, but it sure looks like a copy/paste bug to me
I've made the fix on ``rrule-alt``` (see #160 (comment))

@espen espen added the bug label Jan 16, 2018
@espen
Copy link
Collaborator

espen commented Jan 16, 2018

Can you make it into a pull request @arolson101 ?

arolson101 added a commit that referenced this issue Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants