Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLICOLOR, require non-empty values, suggest CLI options #20

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Add CLICOLOR, require non-empty values, suggest CLI options #20

merged 2 commits into from
Apr 17, 2024

Conversation

adamhotep
Copy link
Contributor

Closes #13 & #18

@adamhotep
Add CLICOLOR environment variable
ad74e7f 
Also added recommended `--color` command-line options (a la GNU ls) to override.
@adamhotep
Require non-empty values
10f67ca 
Closes jhasse#13
@jhasse jhasse merged commit 5eefe33 into jhasse:gh-pages Apr 17, 2024
@adamhotep
Copy link
Contributor Author

Is it me, or was my fix to #13 (see commit 10f67ca) not incorporated?

@jhasse
Copy link
Owner

jhasse commented Apr 21, 2024

see #21

@adamhotep
Copy link
Contributor Author

Ah, I don't know how the if/elif lines vanished. I've re-submitted the correct logic as #22.

This was referenced Jun 4, 2024
Open
Open
epage added a commit to epage/anstyle that referenced this pull request Jun 4, 2024
@epage
fix(query)!: Update CLICOLOR_FORCE to check non-empty
1d210c7 
CLICOLOR_FORCE was changed in jhasse/clicolors#12 then jhasse/clicolors#20
@epage epage mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NO_COLOR spec has changed
2 participants
@adamhotep @jhasse