Implement #693, fixed some suggestions from #883 (v2)

[pstasiak]

#693

Squashed and changed destination branch version of #1443

[jessesquires]

oops. this shouldn't have been removed.

---

my previous comment was for removing @optional from JSQMessageMediaData.h. however, let's actually leave JSQMessageMediaData.h how you have it, since copying JSQVideoMediaItem is not yet implemented

[jessesquires]

Thanks so much @pstasiak !

• 1 last comment
• 1 question: is it possible to provide an apple maps URL for location items? that seems like a more sensible library default. if not, the google URL is good!

Don't worry about squashing for these updates! 😄

[pstasiak]

is it possible to provide an apple maps URL for location items?

It was possible :) The only thing is that we are not providing any annotation title for now (JSQLocationMediaItem doesn't utilize title; other option is to add localized string like "location").

@jessesquires I will squash again when you are happy with my changes :)

[jessesquires]

The only thing is that we are not providing any annotation title for now (JSQLocationMediaItem doesn't utilize title; other option is to add localized string like "location").

Is this something we can add to JSQLocationMediaItem?

[jessesquires]

Ping @pstasiak 😄 😄

[pstasiak]

Oh, thanks for pinging @jessesquires ;)

Is this something we can add to JSQLocationMediaItem?

I don't feel that adding custom field to JSQLocationMediaItem is something in scope of this PR. I could add static localized string for now (MVP, right ;)?), but I'm unable to provide translations in all supported languages. How do you manage translations?

[jessesquires]

Got it 👍

How do you manage translations?

This is all community provided. Anything not there will default to en. But, there are hooks for clients to override existing strings and completely opt-out of localization.

[jessesquires]

thanks again @pstasiak ! 😄