Implement UIMenu "copy" actions for media items/cells

[jessesquires]

Currently, the library ignores the copy action for media cells.

Media items and data to copy to clipboard:

• JSQPhotoMediaItem — copy the photo (done in Implement #693, fixed some suggestions from #883 (v2) #1447)
• JSQLocationMediaItem — copy the location coordinates? copy the address (requires reverse-geocoding)? copy map link (done in Implement #693, fixed some suggestions from #883 (v2) #1447)
• JSQVideoMediaItem — copy the URL? copy the video

Any feedback is welcome here!

---

Remaining TODOs:

• See progress from PR Implement #693, fixed some suggestions from #883 (v2) #1447
• Once JSQVideoMediaItem is implemented, let's make all protocol methods non-optional

[pflenker]

Hi,

my suggestion to (3) is to not copy the URL to the video, since this URL is
meaningless anywhere outside the app (at least, as long as it is not an URL
to a remote web server). I'd copy the video instead
To (2): reverse-geocoding might not be available at all times, and takes
some time to complete. Lat/Lon coordinates are meaningless to most users.
How about building a map link
https://developer.apple.com/library/ios/featuredarticles/iPhoneURLScheme_Reference/MapLinks/MapLinks.html
to Apple Maps or Google Maps?

Best regards,
Philipp

On 24 December 2014 at 17:22, Jesse Squires notifications@github.com
wrote:

Currently, the library ignores the copy action for media cells.

Media items and data to copy to clipboard:

1. JSQPhotoMediaItem — copy the photo
2. JSQLocationMediaItem — copy the location coordinates? copy the
   address (requires reverse-geocoding)?
3. JSQVideoMediaItem — copy the URL? copy the video?

Any feedback is welcome here!

—
Reply to this email directly or view it on GitHub
#693.

[jessesquires]

Great ideas @pflenker !

[jeffkibuule]

I gave this one a try. First real open-source contribution, plus some ok-ish tests. Still scratching my head on video, it'll copy, but shows up as a generic file instead of a video. I left out support for it at the moment.

[wdcurry]

ignoring the need to implement copy, is the pathway to a custom action on a media bubble available at this point in time?

[wdcurry]

For what it is worth, i augmented JSQMessagesViewController.m to not ignore the menu, and then trapped the copy selector to remove it from the popup menu.. good to go.

[jessesquires]

@wdcurry - see https://github.com/jessesquires/JSQMessagesViewController/releases/tag/7.1.0