This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Implement #693, fixed some suggestions from #883. #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new optional protocol method `copyableMediaItem` on `JSQMessageMediaData` indicating ability to represent media item in form that can be copied to UIPasteboard. Returns `NSDictionary` representation of item with new constants to access items. - Implement ability to copy `JSQLocationMediaItem` as NSURL linking to Google Maps (lat/lng) - Implement ability to copy `JSQPhotoMediaItem` as NSData copyable to other apps (JPEG representation) - Update `JSQMessageViewController` to allow copying of items that implement optional `copyableMediaItem` method on `JSQMessageMediaData`. - Added `MobileCoreServices` framework needed for UTTypes constants. - Added tests for new `copyableMediaItem` functionality for both `JSQLocationMediaItem` and `JSQPhotoMediaItem` I also tried to add the same copy functionality to `JSQVideoMediaItem` but am scratching my head as to what the correct UTType is. The file itself is perfectly intact when emailed and file extension is re-added so it's something else... *smh*
jessesquires
changed the title
| * @discussion You should return an object that is of a class type appropriate to the representation type, | ||
| * which typically is a UTI. | ||
| */ | ||
| - (id)copyableData; |
There was a problem hiding this comment.
let's name these new methods:
- (NSString *)mediaDataType;
- (id)mediaData;| @@ -78,4 +78,24 @@ | |||
| */ | |||
| - (NSUInteger)mediaHash; | |||
|
|
|||
| @optional | |||
There was a problem hiding this comment.
I think I'd like to target this feature for the 8.0 release, so we can make a breaking change and have this be non-optional instead
|
Thanks @pstasiak ! This looks great! 😄 👍
|
|
Oh, also -- if you could squash these commits into a single commit, that would be awesome! |
|
Awesome! Thanks @pstasiak ! |
|
Ha, it only took a year to get done. Yay open source! Apologies I couldn't be the one to do this myself, but I'm glad I laid the foundation. |
|
Thanks @jeffkibuule ! 😄 We didn't merge your code, but we did merge your ideas. 😄 |
|
Awesome, open idea contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #693, fixed some suggestions from #883.