Implement Date.UTC and add a dummy implementation for Date.now #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| ECMA_FINALIZE (seconds_value); | ||
| } | ||
|
|
||
| if (args_len == 7 && ecma_is_completion_value_empty (ret_value)) |
There was a problem hiding this comment.
IMHO, if a user passes 8 arguments we should work in that case also, we just won't do anything with the 8th argument.
There was a problem hiding this comment.
Sure, I'l fix it.
LaszloLango
added
ecma builtins
LaszloLango
force-pushed
the
date_now_utc_dev
branch
from
8c0c78d to
2d000ce
Compare
| * When the UTC function is called with fewer than two arguments, | ||
| * the behaviour is implementation-dependent, so just return NaN. | ||
| */ | ||
| ecma_number_t *nan = ecma_alloc_number (); |
There was a problem hiding this comment.
Probably it should be nan_p.
LaszloLango
force-pushed
the
date_now_utc_dev
branch
2 times, most recently
from
d48d264 to
1b22e19
Compare
|
lgtm |
| ecma_number_t seconds = ECMA_NUMBER_ZERO; | ||
| ecma_number_t milliseconds = ECMA_NUMBER_ZERO; | ||
|
|
||
| if (args_len >= 3 && ecma_is_completion_value_empty (ret_value)) |
There was a problem hiding this comment.
Please add comment for each condition corresponding to http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.3.1 bullets.
LaszloLango
force-pushed
the
date_now_utc_dev
branch
from
1b22e19 to
0bb94b3
Compare
|
@egavrin, I've updated the PR, please check. |
|
Good to me |
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
LaszloLango
force-pushed
the
date_now_utc_dev
branch
from
0bb94b3 to
4f108ab
Compare
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com