Implement Date constructor. #322

LaszloLango · 2015-07-07T08:23:00Z

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

LaszloLango · 2015-07-07T08:24:00Z

~~Depends on #305~~

galpeter · 2015-07-07T08:30:48Z

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

+  }
+  else
+  {
+    prim_value_num_p= ecma_alloc_number ();


Space before =

galpeter · 2015-07-07T10:54:29Z

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

+                      ret_value);
+
+      prim_value_num_p = ecma_alloc_number ();
+      *prim_value_num_p = *ecma_get_number_from_completion_value (parse_res_value);


Should this be ecma_get_number_from_value ? As the parse_res_value is not a completion value.

why is parse_res_value not a completion value?

See: https://github.com/Samsung/jerryscript/blob/master/jerry-core/ecma/operations/ecma-try-catch-macro.h#L43

I missed that. I'll fix it

ruben-ayrapetyan · 2015-07-07T14:54:19Z

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

+
+    ret_value = ecma_make_normal_completion_value (ecma_make_object_value (obj_p));
+  }
+  else if (ecma_is_completion_value_throw (ret_value))


JERRY_ASSERT?

@ruben-ayrapetyan, sorry, I don't get it. What do you mean exactly? What would you like to test with the assert?

@LaszloLango, I mean that ret_value can be either empty or contain throw value just before the if block. Here we handle empty case in if and throw in else if. As there should be no other cases, we could just assert this, replacing else if with else and adding JERRY_ASSERT with contents of current else if condition to the else block.

Like the following:

if (ecma_is_completion_value_empty (ret_value)) { ... } else { JERRY_ASSERT (ecma_is_completion_value_throw (ret_value)); ... }

@ruben-ayrapetyan, I see. Thanks for explain. I'll do it.

@LaszloLango, thank you.

galpeter · 2015-07-07T15:09:47Z

tests/jerry/date-construct.js

+}
+catch (e)
+{
+  assert (e.toString() == "Error: foo");


We usually test it this way:

assert (e instanceof Error); assert (e.message === "foo");

but this is also ok imho.

LaszloLango · 2015-07-07T15:27:19Z

@galpeter, @ruben-ayrapetyan, I've updated the PR.

ruben-ayrapetyan · 2015-07-07T16:13:49Z

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

+    ecma_property_t *prim_value_prop_p = ecma_create_internal_property (obj_p,
+                                                                        ECMA_INTERNAL_PROPERTY_PRIMITIVE_NUMBER_VALUE);
+    ECMA_SET_POINTER (prim_value_prop_p->u.internal_property.value, prim_value_num_p);
+


We can use ECMA_SET_NON_NULL_POINTER in the case, as prim_value_num_p is not NULL.

ruben-ayrapetyan · 2015-07-07T16:14:17Z

Looks good to me

egavrin · 2015-07-07T16:16:36Z

make push

galpeter · 2015-07-08T08:51:00Z

lgtm

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

LaszloLango added ecma builtins Related to ECMA built-in routines development Feature implementation labels Jul 7, 2015

LaszloLango assigned egavrin Jul 7, 2015

LaszloLango added this to the ECMA builtins milestone Jul 7, 2015

galpeter reviewed Jul 7, 2015
View reviewed changes

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

}

else

{

prim_value_num_p= ecma_alloc_number ();

Copy link

Contributor

galpeter Jul 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before =

LaszloLango force-pushed the date_construct_dev branch from c2e2472 to 225d533 Compare July 7, 2015 10:29

galpeter reviewed Jul 7, 2015
View reviewed changes

LaszloLango force-pushed the date_construct_dev branch from 225d533 to 63a8efe Compare July 7, 2015 14:14

ruben-ayrapetyan reviewed Jul 7, 2015
View reviewed changes

LaszloLango force-pushed the date_construct_dev branch from 63a8efe to 3d49ab7 Compare July 7, 2015 15:01

egavrin assigned ruben-ayrapetyan and unassigned egavrin Jul 7, 2015

galpeter reviewed Jul 7, 2015
View reviewed changes

LaszloLango force-pushed the date_construct_dev branch from 3d49ab7 to 475a7f9 Compare July 7, 2015 15:26

ruben-ayrapetyan reviewed Jul 7, 2015
View reviewed changes

ruben-ayrapetyan assigned egavrin and unassigned ruben-ayrapetyan Jul 7, 2015

egavrin assigned LaszloLango and unassigned egavrin Jul 7, 2015

LaszloLango force-pushed the date_construct_dev branch from 475a7f9 to 0af000c Compare July 8, 2015 08:55

Implement Date constructor.

c12914c

JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com

LaszloLango force-pushed the date_construct_dev branch from 0af000c to c12914c Compare July 8, 2015 09:09

LaszloLango merged commit c12914c into jerryscript-project:master Jul 8, 2015

galpeter mentioned this pull request Jul 8, 2015

Implement ECMA262 Date builtin object #94

Closed

50 tasks

LaszloLango deleted the date_construct_dev branch December 14, 2015 09:07

Implement Date constructor. #322

Implement Date constructor. #322

Uh oh!

Conversation

LaszloLango commented Jul 7, 2015

Uh oh!

LaszloLango commented Jul 7, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LaszloLango commented Jul 7, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ruben-ayrapetyan commented Jul 7, 2015

Uh oh!

egavrin commented Jul 7, 2015

Uh oh!

galpeter commented Jul 8, 2015

Uh oh!

Uh oh!