Skip to content

Commit 2d000ce

Browse files
committed
Implement Date.UTC and add a dummy implementation for Date.now
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
1 parent ae3eea8 commit 2d000ce

File tree

2 files changed

+184
-4
lines changed

2 files changed

+184
-4
lines changed

jerry-core/ecma/builtin-objects/ecma-builtin-date.cpp

Lines changed: 135 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@
1515
*/
1616

1717
#include "ecma-alloc.h"
18+
#include "ecma-builtin-helpers.h"
19+
#include "ecma-conversion.h"
1820
#include "ecma-globals.h"
1921
#include "ecma-helpers.h"
22+
#include "ecma-try-catch-macro.h"
2023

2124
#ifndef CONFIG_ECMA_COMPACT_PROFILE_DISABLE_DATE_BUILTIN
2225

@@ -37,11 +40,110 @@
3740
* @{
3841
*/
3942

43+
/**
44+
* Calculate MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli)) for Date constructor and UTC
45+
*
46+
* See also:
47+
* ECMA-262 v5, 15.9.3.1
48+
* ECMA-262 v5, 15.9.4.3
49+
*
50+
* @return result of MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))
51+
*/
52+
static ecma_completion_value_t
53+
ecma_date_construct_helper (const ecma_value_t *args, /**< arguments passed to the Date constructor */
54+
ecma_length_t args_len) /**< number of arguments */
55+
{
56+
ecma_completion_value_t ret_value = ecma_make_empty_completion_value ();
57+
ecma_number_t *prim_value_p = ecma_alloc_number ();
58+
*prim_value_p = ecma_number_make_nan ();
59+
60+
ECMA_TRY_CATCH (year_value, ecma_op_to_number (args[0]), ret_value);
61+
ECMA_TRY_CATCH (month_value, ecma_op_to_number (args[1]), ret_value);
62+
63+
ecma_number_t year = *ecma_get_number_from_value (year_value);
64+
ecma_number_t month = *ecma_get_number_from_value (month_value);
65+
ecma_number_t date = ECMA_NUMBER_ONE;
66+
ecma_number_t hours = ECMA_NUMBER_ZERO;
67+
ecma_number_t minutes = ECMA_NUMBER_ZERO;
68+
ecma_number_t seconds = ECMA_NUMBER_ZERO;
69+
ecma_number_t milliseconds = ECMA_NUMBER_ZERO;
70+
71+
if (args_len >= 3 && ecma_is_completion_value_empty (ret_value))
72+
{
73+
ECMA_TRY_CATCH (date_value, ecma_op_to_number (args[2]), ret_value);
74+
date = *ecma_get_number_from_value (date_value);
75+
ECMA_FINALIZE (date_value);
76+
}
77+
78+
if (args_len >= 4 && ecma_is_completion_value_empty (ret_value))
79+
{
80+
ECMA_TRY_CATCH (hours_value, ecma_op_to_number (args[3]), ret_value);
81+
hours = *ecma_get_number_from_value (hours_value);
82+
ECMA_FINALIZE (hours_value);
83+
}
84+
85+
if (args_len >= 5 && ecma_is_completion_value_empty (ret_value))
86+
{
87+
ECMA_TRY_CATCH (minutes_value, ecma_op_to_number (args[4]), ret_value);
88+
minutes = *ecma_get_number_from_value (minutes_value);
89+
ECMA_FINALIZE (minutes_value);
90+
}
91+
92+
if (args_len >= 6 && ecma_is_completion_value_empty (ret_value))
93+
{
94+
ECMA_TRY_CATCH (seconds_value, ecma_op_to_number (args[5]), ret_value);
95+
seconds = *ecma_get_number_from_value (seconds_value);
96+
ECMA_FINALIZE (seconds_value);
97+
}
98+
99+
if (args_len >= 7 && ecma_is_completion_value_empty (ret_value))
100+
{
101+
ECMA_TRY_CATCH (milliseconds_value, ecma_op_to_number (args[6]), ret_value);
102+
milliseconds = *ecma_get_number_from_value (milliseconds_value);
103+
ECMA_FINALIZE (milliseconds_value);
104+
}
105+
106+
if (ecma_is_completion_value_empty (ret_value))
107+
{
108+
if (!ecma_number_is_nan (year))
109+
{
110+
int32_t y = ecma_number_to_int32 (year);
111+
if (y >= 0 && y <= 99)
112+
{
113+
year = (ecma_number_t) (1900 + y);
114+
}
115+
else
116+
{
117+
year = (ecma_number_t) y;
118+
}
119+
}
120+
121+
*prim_value_p = ecma_date_make_date (ecma_date_make_day (year,
122+
month,
123+
date),
124+
ecma_date_make_time (hours,
125+
minutes,
126+
seconds,
127+
milliseconds));
128+
}
129+
130+
ECMA_FINALIZE (month_value);
131+
ECMA_FINALIZE (year_value);
132+
133+
if (ecma_is_completion_value_empty (ret_value))
134+
{
135+
ret_value = ecma_make_normal_completion_value (ecma_make_number_value (prim_value_p));
136+
}
137+
138+
return ret_value;
139+
}
140+
40141
/**
41142
* The Date object's 'parse' routine
42143
*
43144
* See also:
44145
* ECMA-262 v5, 15.9.4.2
146+
* ECMA-262 v5, 15.9.1.15
45147
*
46148
* @return completion value
47149
* Returned value must be freed with ecma_free_completion_value.
@@ -63,11 +165,33 @@ ecma_builtin_date_parse (ecma_value_t this_arg, /**< this argument */
63165
* Returned value must be freed with ecma_free_completion_value.
64166
*/
65167
static ecma_completion_value_t
66-
ecma_builtin_date_utc (ecma_value_t this_arg, /**< this argument */
168+
ecma_builtin_date_utc (ecma_value_t this_arg __attr_unused___, /**< this argument */
67169
const ecma_value_t args[], /**< arguments list */
68170
ecma_length_t args_number) /**< number of arguments */
69171
{
70-
ECMA_BUILTIN_CP_UNIMPLEMENTED (this_arg, args, args_number);
172+
ecma_completion_value_t ret_value = ecma_make_empty_completion_value ();
173+
174+
if (args_number < 2)
175+
{
176+
/* Note:
177+
* When the UTC function is called with fewer than two arguments,
178+
* the behaviour is implementation-dependent, so just return NaN.
179+
*/
180+
ecma_number_t *nan = ecma_alloc_number ();
181+
*nan = ecma_number_make_nan ();
182+
return ecma_make_normal_completion_value (ecma_make_number_value (nan));
183+
}
184+
185+
ECMA_TRY_CATCH (time_value, ecma_date_construct_helper (args, args_number), ret_value);
186+
187+
ecma_number_t *time_p = ecma_get_number_from_completion_value (time_value);
188+
ecma_number_t *time_clip = ecma_alloc_number ();
189+
*time_clip = ecma_date_time_clip (*time_p);
190+
ret_value = ecma_make_normal_completion_value (ecma_make_number_value (time_clip));
191+
192+
ECMA_FINALIZE (time_value);
193+
194+
return ret_value;
71195
} /* ecma_builtin_date_utc */
72196

73197
/**
@@ -80,9 +204,16 @@ ecma_builtin_date_utc (ecma_value_t this_arg, /**< this argument */
80204
* Returned value must be freed with ecma_free_completion_value.
81205
*/
82206
static ecma_completion_value_t
83-
ecma_builtin_date_now (ecma_value_t this_arg) /**< this argument */
207+
ecma_builtin_date_now (ecma_value_t this_arg __attr_unused___) /**< this argument */
84208
{
85-
ECMA_BUILTIN_CP_UNIMPLEMENTED (this_arg);
209+
/*
210+
* FIXME:
211+
* Get the real system time. ex: gettimeofday() on Linux
212+
* Introduce system macros at first.
213+
*/
214+
ecma_number_t *now_num_p = ecma_alloc_number ();
215+
*now_num_p = ECMA_NUMBER_ZERO;
216+
return ecma_make_normal_completion_value (ecma_make_number_value (now_num_p));
86217
} /* ecma_builtin_date_now */
87218

88219
/**

tests/jerry/date-utc.js

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
// Copyright 2015 Samsung Electronics Co., Ltd.
2+
// Copyright 2015 University of Szeged.
3+
//
4+
// Licensed under the Apache License, Version 2.0 (the License);
5+
// you may not use this file except in compliance with the License.
6+
// You may obtain a copy of the License at
7+
//
8+
// http://www.apache.org/licenses/LICENSE, 2.0
9+
//
10+
// Unless required by applicable law or agreed to in writing, software
11+
// distributed under the License is distributed on an AS IS BASIS
12+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
// See the License for the specific language governing permissions and
14+
// limitations under the License.
15+
16+
var d;
17+
18+
d = Date.UTC(undefined);
19+
assert (isNaN(d));
20+
21+
d = Date.UTC({});
22+
assert (isNaN(d));
23+
24+
d = Date.UTC(2015);
25+
assert (isNaN(d));
26+
27+
d = Date.UTC(2000 + 15, 0);
28+
assert (d == 1420070400000);
29+
30+
d = Date.UTC(2015, 0);
31+
assert (d == 1420070400000);
32+
33+
d = Date.UTC(2015, 0, 1);
34+
assert (d == 1420070400000);
35+
36+
d = Date.UTC(2015, 0, 1, 0);
37+
assert (d == 1420070400000);
38+
39+
d = Date.UTC(2015, 0, 1, 0, 0);
40+
assert (d == 1420070400000);
41+
42+
d = Date.UTC(2015, 0, 1, 0, 0, 0);
43+
assert (d == 1420070400000);
44+
45+
d = Date.UTC(2015, 0, 1, 0, 0, 0, 0);
46+
assert (d == 1420070400000);
47+
48+
d = Date.UTC(2015, 6, 3, 14, 35, 43, 123);
49+
assert (d == 1435934143123);

0 commit comments

Comments
 (0)