Deprecate APIs that are deprecated only on JavaDoc (facebook#37229)

Summary: Pull Request resolved: facebook#37229 Those methods all have replacements and they have been annotated as `deprecated` but only on the Javadoc level. The Java compiler from 11 starts to emit warnigns for those functions so I'm actually annotating them with Deprecated correctly. Changelog: [Android] [Changed] - Deprecate APIs that are deprecate only on JavaDoc Reviewed By: mdvacca Differential Revision: D45525406 fbshipit-source-id: 9fea1a6374c9a14f7f07e5bca8db1221260c03fd
jeongshin · May 7, 2023 · 0816ef4 · 0816ef4
1 parent 991d29b
commit 0816ef4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 0 deletions.
diff --git a/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
@@ -555,6 +555,7 @@ private void toggleElementInspector() {
    * @deprecated Use {@link #onHostPause(Activity)} instead.
    */
   @ThreadConfined(UI)
+  @Deprecated
   public void onHostPause() {
     UiThreadUtil.assertOnUiThread();
 
@@ -669,6 +670,7 @@ public void onViewDetachedFromWindow(View v) {
    * @deprecated use {@link #onHostDestroy(Activity)} instead
    */
   @ThreadConfined(UI)
+  @Deprecated
   public void onHostDestroy() {
     UiThreadUtil.assertOnUiThread();
 

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
@@ -52,6 +52,7 @@ interface NativeMethod {
    *
    * @deprecated use {@link #invalidate()} instead.
    */
+  @Deprecated
   void onCatalystInstanceDestroy();
 
   /** Allow NativeModule to clean up. Called before {CatalystInstance#onHostDestroy} */

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java
@@ -516,6 +516,7 @@ public boolean startActivityForResult(Intent intent, int code, Bundle bundle) {
   }
 
   /** @deprecated DO NOT USE, this method will be removed in the near future. */
+  @Deprecated
   public boolean isBridgeless() {
     return false;
   }

diff --git a/...ative/ReactAndroid/src/main/java/com/facebook/react/modules/common/ModuleDataCleaner.java b/...ative/ReactAndroid/src/main/java/com/facebook/react/modules/common/ModuleDataCleaner.java
@@ -43,6 +43,7 @@ public interface Cleanable {
    *
    * @deprecated
    */
+  @Deprecated
   public static void cleanDataFromModules(CatalystInstance catalystInstance) {
     for (NativeModule nativeModule : catalystInstance.getNativeModules()) {
       if (nativeModule instanceof Cleanable) {

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootView.java
@@ -20,6 +20,7 @@ public interface RootView {
   void onChildStartedNativeGesture(View childView, MotionEvent ev);
 
   /** @deprecated */
+  @Deprecated
   void onChildStartedNativeGesture(MotionEvent ev);
 
   /**