do not expose logger from RCTHost (facebook#37235)

Summary: Pull Request resolved: facebook#37235 Changelog: [Internal] we shouldn't expose the logger, only need to expose the logging information Reviewed By: javache Differential Revision: D45513780 fbshipit-source-id: b82496ebcbf87d7f88d6c7e1afea655d4177a0d8
jeongshin · May 7, 2023 · 991d29b · 991d29b
1 parent 742d449
commit 991d29b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.h
@@ -20,7 +20,6 @@ NS_ASSUME_NONNULL_BEGIN
 @class RCTFabricSurface;
 @class RCTJSThreadManager;
 @class RCTModuleRegistry;
-@class RCTPerformanceLogger;
 @protocol RCTInstanceDelegate;
 FB_RUNTIME_PROTOCOL
 @protocol RCTTurboModuleManagerDelegate;
@@ -74,7 +73,7 @@ RCT_EXTERN NSString *const RCTHostDidReloadNotification;
 
 - (RCTModuleRegistry *)getModuleRegistry FB_OBJC_DIRECT;
 
-- (RCTPerformanceLogger *)getPerformanceLogger FB_OBJC_DIRECT;
+- (NSArray *)getLoggingData FB_OBJC_DIRECT;
 
 - (RCTSurfacePresenter *)getSurfacePresenter FB_OBJC_DIRECT;
 

diff --git a/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm b/packages/react-native/ReactCommon/react/bridgeless/platform/ios/Core/RCTHost.mm
@@ -14,6 +14,7 @@
 #import <React/RCTFabricSurface.h>
 #import <React/RCTJSThread.h>
 #import <React/RCTLog.h>
+#import <React/RCTPerformanceLogger.h>
 #import <React/RCTReloadCommand.h>
 
 using namespace facebook::react;
@@ -201,9 +202,9 @@ - (RCTModuleRegistry *)getModuleRegistry
   return _moduleRegistry;
 }
 
-- (RCTPerformanceLogger *)getPerformanceLogger
+- (NSArray *)getLoggingData
 {
-  return [_instance performanceLogger];
+  return [[_instance performanceLogger] valuesForTags];
 }
 
 - (RCTSurfacePresenter *)getSurfacePresenter