Deprecate APIs that are deprecate only on JavaDoc #37229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45525406 |
Base commit: 71fbb0c |
Summary: Pull Request resolved: facebook#37229 Those methods all have replacements and they have been annotated as `deprecated` but only on the Javadoc level. The Java compiler from 11 starts to emit warnigns for those functions so I'm actually annotating them with Deprecated correctly. Changelog: [Android] [Changed] - Deprecate APIs that are deprecate only on JavaDoc Reviewed By: mdvacca Differential Revision: D45525406 fbshipit-source-id: f9e7469614053a23c353437837ee47bd84cfabf0
|
This pull request was exported from Phabricator. Differential Revision: D45525406 |
cortinico
force-pushed
the
export-D45525406
branch
from
c36ce03
to
3a78304
Compare
|
This pull request has been merged in 1be65ba. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37229 Those methods all have replacements and they have been annotated as `deprecated` but only on the Javadoc level. The Java compiler from 11 starts to emit warnigns for those functions so I'm actually annotating them with Deprecated correctly. Changelog: [Android] [Changed] - Deprecate APIs that are deprecate only on JavaDoc Reviewed By: mdvacca Differential Revision: D45525406 fbshipit-source-id: 9fea1a6374c9a14f7f07e5bca8db1221260c03fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Those methods all have replacements and they have been annotated as
deprecatedbut only on the Javadoc level.The Java compiler from 11 starts to emit warnigns for those functions so I'm actually annotating them with Deprecated correctly.
Changelog:
[Android] [Changed] - Deprecate APIs that are deprecate only on JavaDoc
Differential Revision: D45525406