Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate APIs that are deprecate only on JavaDoc #37229

Closed
wants to merge 1 commit into from
Closed

Deprecate APIs that are deprecate only on JavaDoc #37229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ private void toggleElementInspector() {
* @deprecated Use {@link #onHostPause(Activity)} instead.
*/
@ThreadConfined(UI)
@Deprecated
public void onHostPause() {
UiThreadUtil.assertOnUiThread();

Expand Down Expand Up @@ -669,6 +670,7 @@ public void onViewDetachedFromWindow(View v) {
* @deprecated use {@link #onHostDestroy(Activity)} instead
*/
@ThreadConfined(UI)
@Deprecated
public void onHostDestroy() {
UiThreadUtil.assertOnUiThread();

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ interface NativeMethod {
*
* @deprecated use {@link #invalidate()} instead.
*/
@Deprecated
void onCatalystInstanceDestroy();

/** Allow NativeModule to clean up. Called before {CatalystInstance#onHostDestroy} */
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ public boolean startActivityForResult(Intent intent, int code, Bundle bundle) {
}

/** @deprecated DO NOT USE, this method will be removed in the near future. */
@Deprecated
public boolean isBridgeless() {
return false;
}
Expand Down
1 change: 1 addition & 0 deletions ...ative/ReactAndroid/src/main/java/com/facebook/react/modules/common/ModuleDataCleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public interface Cleanable {
*
* @deprecated
*/
@Deprecated
public static void cleanDataFromModules(CatalystInstance catalystInstance) {
for (NativeModule nativeModule : catalystInstance.getNativeModules()) {
if (nativeModule instanceof Cleanable) {
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/RootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public interface RootView {
void onChildStartedNativeGesture(View childView, MotionEvent ev);

/** @deprecated */
@Deprecated
void onChildStartedNativeGesture(MotionEvent ev);

/**
Expand Down