Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow access to the options page from the popup of the extension #19

Closed
carbon-steel opened this issue Apr 6, 2017 · 0 comments
Closed

Allow access to the options page from the popup of the extension #19

carbon-steel opened this issue Apr 6, 2017 · 0 comments
Assignees
@jchang504
Labels
feature involved P1
Milestone
v1.0.0 Release Ready

Comments

@carbon-steel
Copy link
Collaborator

carbon-steel commented Apr 6, 2017 •
edited
Loading

Having to open another tab to reach the options page expends more mental effort than necessary. This leads to a not-so-seamless user experience. It would feel much smoother if the hotkeys settings were available right from the chrome extension popup (perhaps as a tab of the popup).
@jchang504 jchang504 mentioned this issue Jun 4, 2017
Open
@jchang504 jchang504 added this to the v1.0.0 Release Ready milestone Jul 5, 2017
@jchang504 jchang504 added P1 and removed P2 labels Jul 5, 2017
@jchang504 jchang504 self-assigned this Jul 5, 2017
@jchang504 jchang504 mentioned this issue Jul 5, 2017
Open
jchang504 added a commit that referenced this issue Jul 26, 2017
@jchang504
Add unsaved options warning on close (part of #26)
ceaa1ef 
Unfortunately, there's no way to give the warning when the user closes the
window in general, but we can at least do it when they use our "Close" button.
The button also displays when there are unsaved changes with different text. I
want to get the save and close buttons to float and always stay on screen, but
I can't get position: fixed to work within the extension options page. Since
we're going to be moving the options to the popup anyway (#19), I'll try it
then.
@jchang504 jchang504 mentioned this issue Jul 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchang504 jchang504

Labels
feature involved P1
Projects
None yet
Milestone
v1.0.0 Release Ready
Development

No branches or pull requests
2 participants
@jchang504 @carbon-steel