Fix up the UI of the options page #20
Comments
This was referenced Jun 10, 2017
jchang504
added a commit
that referenced
this issue
Jul 1, 2017
The hotkey entries in the options now have an additional field, Match Prefix, that is required only when Deduplicate is checked. Any tab with a URL starting with the Match Prefix is considered a match to this hotkey for deduplication purposes, but the Target (which can the same or more specific than Match Prefix) is the URL that will be opened if no match already exists. Important note: the Match Prefix has to be usable as a Chrome "URL match pattern" when just a "*" is added to the end of it, so I added a rudimentary regex validation on its input element. For some reason (I'm guessing related to Foundation), the default popups aren't appearing when the user tries to save with an invalid Match Prefix, but the page simply focuses the first box with an invalid input, which is very unclear. Much clearer notification of what's invalid and how to fix it should be a part of #20. Also, this commit removes the legacy code for loading and converting the old format of options, as planned. Options will not load correctly for any user who has not first saved their options with the previous commit's code. (But they can just check out the previous commit, open and save their options, then checkout this commit again.)
|
Make sure to cover #26 as part of this. |
|
Also, make deduplicate the default and make "always open in new tab" a less prominent additional option, and overhaul the codebase to remove the term "deduplicate". |
|
Also, get rid of Foundation. |
|
Might as well do #19 as part of this. |
|
Add a checkbox "Use target as match prefix" which disables the match prefix input (but mirrors the target's value in it for clarity), so the user doesn't have to copy paste if they just want to use the target as the match prefix. |
|
When saving hotkeys fails, make sure that it is abundantly clear to the user that it did fail. |
jchang504
added a commit
that referenced
this issue
Jul 13, 2017
Display automatic URL adjustments to Target and Match Prefix fields immediately upon save, rather than silently showing up the next time the user opens options. Part of UI cleanup, issue #20.
jchang504
added a commit
that referenced
this issue
Jul 26, 2017
The start of cleaning up the options page UI (#20).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was okay during the hackathon, but it's pretty ugly
The text was updated successfully, but these errors were encountered: