make saving hotkeys more user-friendly

[carbon-steel]

It's easy to make a new hotkey and then just close the window. We should have autosaving (or give the save button a better UI, maybe always keep it on the screen).

[jchang504]

Auto-saving is pretty dangerous, don't like that. I thought you were thinking about moving the options into the browser action popup (#19)? We could do some UI tweaks along with that. We can even make the browser action popup only for configuring options if we implement #27.

[carbon-steel]

My continued experience with the UI makes me think autosaving should really be implemented. It's so easy to just close the options page after making the change that you want.

[jchang504]

I would prefer keeping the save button on screen as you first suggested, with a confirmation popup if the user closes the options page with unsaved changes. The window should also be a lot wider to see more of the URLs. There's a lot wrong with the options page UI; this issue should just be linked in as part of #20.

[jchang504]

With the options page now in the popup, it's very easy to close it by just clicking outside the popup box (and unfortunately, there's no way to detect/block this event or show a warning before it closes). Thus, my handy close button with its unsaved changes warning isn't all that helpful if the user doesn't use it and instead just clicks outside the box. So I'm thinking we'll have to go with auto-saving (in conjunction with on-input validation that Jason is working on that will make it very obvious when you have invalid inputs which prevent auto-saving).

The main thing that worries me about auto-saving is the possibility of accidentally clicking the delete button on a hotkey row and having to re-enter it all from memory. The only solution I can think of for that is having an undo button (specifically for deletes), which I can do but it's a bit of work... any better ideas @Sophtware?

[jchang504]

Update: we're narrowing down to an auto-save solution. I've already implemented the "Restore" button (2d9bfee) that I suggested in the previous comment.

[jchang504]

As an aside, I just noticed that my warning when you click close with unsaved changes is only triggering when the unsaved changes are an entirely filled (valid) hotkey entry. Don't know if this was decided as the intended behavior when Jason implemented this, but it seems like a bug to me. In any case, auto-save would eliminate the whole close button thing, so this is probably just for record-keeping.