Reverts to old render settings in kit experience files #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-roth
changed the title
pascal-roth
requested review from
Mayankm96,
hhansen-bdai and
kellyguo11
as code owners
kellyguo11
reviewed
Feb 28, 2025
Contributor
kellyguo11
left a comment
kellyguo11
left a comment
There was a problem hiding this comment.
would be good to also double check the RenderCfg settings to make sure there aren't any conflicts with the changes in the kit files.
kellyguo11
approved these changes
Mar 3, 2025
Mayankm96
changed the title
Contributor
|
@pascal-roth I think this change somehow broke the test_environments.py test, seems like it's generating a bunch of renderer-related errors and timing out. would you mind taking a look at it? |
jtigue-bdai
pushed a commit
that referenced
this pull request
Apr 14, 2025
# Description Reverts to old render settings. Fixes #1844 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots Before:  After:  ## Checklist - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
ToxicNS
pushed a commit
to ToxicNS/IsaacLab
that referenced
this pull request
Apr 24, 2025
# Description Reverts to old render settings. Fixes isaac-sim#1844 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots Before:  After:  ## Checklist - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts to old render settings.
Fixes #1844
Type of change
Screenshots
Before:
After:
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there