feat(ui): do not use thumbnail images as fallbacks #8529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theoretically using thumbnail images as fallbacks provides a better user experience: - Start loading both thumbnail and full image - Render the thumbnail when it is ready - Then render the full image when it is ready, typically _after_ the thumbnail But this does make more network requests, and adds an extra render when we show images (== perf hit). In testing locally, it actually feels snappier without the thumbnail fallback (likely psychosomatic). It certainly does not feel any _worse_, so I think this is a good change.
|
Unfortunately this doesn't play well with #8530 Also, I realized that we the increase in network requests is likely negligible. The gallery loads the thumbnails already, so the vast majority of the time, the browser will have already cached the thumbnail image. So it's just the extra render cycle that we have to pay for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Theoretically using thumbnail images as fallbacks provides a better user experience:
But this does make more network requests, and adds an extra render when we show images (== perf hit). In testing locally, it actually feels snappier without the thumbnail fallback (likely psychosomatic). It certainly does not feel any worse, so I think this is a good change.
Related Issues / Discussions
n/a
QA Instructions
This is kinda experimental. We've used thumbnails for fallbacks for a long time - it's possible that this negatively affects user experience.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)