fix(ui): prev image briefly showing in viewer as progress image "resolves" into output image #8530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
4 tasks
hipsterusername
approved these changes
Sep 4, 2025
This prevents an issue in the image viewer's logic for simulating the progress image "resolving" to a completed image
This tells react that the component is a new instance each time we change the image. Which, in turn, prevents a flash of the previously-selected image during image switching and progress-image-to-output-image-ing.
psychedelicious
force-pushed
the
psyche/fix/ui/image-flashes-in-viewer
branch
from
b872fc0 to
3ded748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is such a tricky thing to solve! At some point - maybe when we were doing video stuff? - it broke again. Fixed now
Related Issues / Discussions
n/a
QA Instructions
Generate on Generate tab, watch the progress image. It should seamlessly "resolve" into the output image.
Merge Plan
n/a
Checklist
What's Newcopy (if doing a release after this PR)